Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 286130

Summary: Change trace output to ensure it can be read back in
Product: [Eclipse Project] Equinox Reporter: Troy Bishop <tjbishop>
Component: FrameworkAssignee: Thomas Watson <tjwatson>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: tjwatson
Version: 3.5   
Target Milestone: 3.6 M2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 285341    
Attachments:
Description Flags
possible solution none

Description Troy Bishop CLA 2009-08-10 10:35:41 EDT 
Build ID: 3.5

While working on bug 285341 I found that the throwable was not being written to the trace file correctly.  The following patch will address this concern and also ensure that the trace file format can be read back in, since the full throwable text, including all stack trace elements, can span multiple lines.  Since the format has changed I bumped the version attribute in the trace file header to 1.1.
Comment 1 Troy Bishop CLA 2009-08-10 10:37:08 EDT 
Created attachment 143916 [details]
possible solution
Comment 2 Thomas Watson CLA 2009-08-10 10:51:12 EDT 
Thanks Troy.  I had noticed this also but forgot to open a bug.  I have not looked at the patch yet but I assume this format change would be too disruptive for 3.5.1.
Comment 3 Troy Bishop CLA 2009-08-10 11:03:42 EDT 
Hi Tom,

If someone is not using the version attribute in the header to ensure compatibility with the way the trace record was written then yes, this change would be disruptive for a 3.5.x release.  The "1.0" version would use the linefeed character as the end of a trace record while the "1.1" version will use the delimeter character defined in EclipseDebugTrace as the end of a trace record.
Comment 4 Thomas Watson CLA 2009-08-12 13:59:58 EDT 
I release the patch to head with one small change.  I added a space before the delimiter '|' when an entry has a throwable.  This was to make it consistent with the other entry elements.