Bugzilla – Full Text Bug Listing
| Summary: | No executable produced during product export with platform-specific root file entries in feature's build.properties | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Jeff Norris <jnorris> | ||||||||
| Component: | Build | Assignee: | pde-build-inbox <pde-build-inbox> | ||||||||
| Status: | RESOLVED WONTFIX | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | aniefer, caniszczyk, jeffmcaffer, luca_quaglia | ||||||||
| Version: | 3.5 | ||||||||||
| Target Milestone: | --- | ||||||||||
| Hardware: | Macintosh | ||||||||||
| OS: | Mac OS X - Carbon (unsup.) | ||||||||||
| Whiteboard: | |||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 309758 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jeff Norris
Can you post your build.properties for the feature? Also, shouldn't your entries be like this? root.linux.gtk.x86.folder.jre=jre1.5.0_18-Linux root.win32.win32.x86.folder.jre=jre1.5.0_18-Win Created attachment 143435 [details]
my build.properties file
I was following these instructions: http://help.eclipse.org/ganymede/index.jsp?topic=/org.eclipse.pde.doc.user/tasks/pde_rootfiles.htm Note that my jre1.5.0_18-Linux and jre1.5.0_18-Win folders have a jre/ subdirectory in them. The jre is being correctly included in the export, it's just not including an executable. Your suggested entries just explicitly include the subdirectory in the entry, but I don't think there's any other difference. I also tried it with your entries with the same results - jre is included, but there's no executable for the platforms mentioned in build.properties. How are you including the delta pack? Created attachment 143436 [details]
my .product file
I'm also including my .product file on the possibility that there's something else that I need to have in here. I admit that some of the platform-specific stuff in the .product file is a bit tricky.
I downloaded the delta pack into a different directory, then edited my target platform and added that directory to it, just like Andrew Niefer's blog post says here: http://aniefer.blogspot.com/2009/06/using-deltapack-in-eclipse-35.html I'm wondering if we're bit by bug 285514 Andrew, any thoughts? oops, I mean this bug 281224: [product] not added to feature based product without deltapack https://bugs.eclipse.org/bugs/show_bug.cgi?id=281224 I suspect this is caused by a collision in the naming of the product-id and the feature the product includes. The executables are automatically packaged into IUs & artifacts named <product-id>_root.<config> Which also happens to be the pattern for rootfiles contributed by features, but with product-id replaced with feature-id. Jeff can you try changing the .product's ID to be different from the feature. Andrew, that fixed it, thanks! We can work around this issue for now by simply giving our product a different ID than any features that are being exported. Since I think that naming products after features probably isn't that uncommon, it's probably a good idea to find some way to namespace them differently. Thanks again! Created attachment 143571 [details]
director log
Here is the director log, produced as requested.
(In reply to comment #12) > Created an attachment (id=143571) [details] > director log > > Here is the director log, produced as requested. > Sorry - this was meant for a different bug. Ignore, please. A good pattern is generally for the product identifier to be the id of the actual product extension (if you have one). This is the case for 99.9% of people. For those who use products and don't have a product extension (or application even) things may be different. I wonder if we could add some PDE UI tooling to detect this type of problem. Is there something you can do at the build level to ease these collisions Andrew? See bug 293111 suggesting errors/warnings on the product file. The product_root IUs have the same structure as feature_root IUs because the product root IU is really just the org.eclipse.equinox.executable feature root IUs branded to match the product. we can look at tweaking the branding a bit. Currently we are not actively enhancing PDE build anymore. Therefore, I close this bug as WONTFIX. Please reopen, if you plan to provide a fix. |