Bug 285144

Description Mathieu Veurman 2009-07-30 08:50:38 EDT

Build ID:  I20090611-1540

The method getCommand() in org.eclipse.gef.tools.DragEditPartsTracker creates a CompoundCommand, but forgets to call unwrap() on it before returning it.

We're supplying a view to our end users that lists the current command stack to the user in a tree. Some MOVE commands that are a result of the DragEditPartsTracker are CompoundCommands with just 1 command in them. unwrap() normally would return the simplest form that is equivalent, and removes this unnecessary nesting.

The change is very easy. Change the last statement of getCommand() from
	return command;
into
	return command.unwrap();


Workaround:
There is a workaround by overriding getDragTracker(Request request) in every edit part you have:

    @Override
    public DragTracker getDragTracker(Request request) {
        return new org.eclipse.gef.tools.DragEditPartsTracker(this) {
            @Override
            protected Command getCommand() {
                Command command = super.getCommand();
                if (command instanceof CompoundCommand) {
                    return ((CompoundCommand)command).unwrap();
                }
                return command;
            }
        };
    }