Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 284401

Summary:	Need to implement ScopingNode#canAddDeclaration
Product:	[Tools] PTP	Reporter:	Jeffrey Overbey <com-eclipse-dot-org>
Component:	Photran.Refactoring Engine	Assignee:	Jeffrey Overbey <com-eclipse-dot-org>
Status:	RESOLVED FIXED	QA Contact:
Severity:	blocker
Priority:	P1	CC:	khendle2
Version:	4.0
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:
Bug Blocks:	285054

Description Jeffrey Overbey

2009-07-23 07:58:18 EDT

The code in the Rename refactoring that determines whether a particular name can be added to a given scope should be moved into a method on ScopingNode (perhaps ScopingNode#canAddDeclaration) so it can be reused in Kurt's Move refactoring.

(Kurt, I'm copying you on this bug so you'll know when I get this done.)

Comment 1 Jeffrey Overbey

2009-09-21 23:27:48 EDT

MakePrivateEntityPublicTestSuite unit test 11 disabled until this is implemented

Comment 2 Jeffrey Overbey

2009-09-21 23:41:09 EDT

Also had to temporarily disable one unit test in Common Consistent refactoring and two in Minimize Only List; are these related?

Comment 3 Kurt Hendle

2009-09-22 11:48:50 EDT

I don't think those should be related. Test 11 MakePrivateEntityPublicTestSuite was the only test dealing with this specifically.

Comment 4 Jeffrey Overbey

2009-09-22 12:56:48 EDT

OK; I just wanted to make sure all the unit tests passed before committing it to CVS.  I'll take a look at those again...

Comment 5 Jeffrey Overbey

2009-10-08 08:27:40 EDT

Implemented as AbstractFortranRefactoring#checkIfDeclarationCanBeAddedToScope

Comment 6 Jeffrey Overbey

2009-10-08 10:48:05 EDT

There is one problem (see FIXME in CheckCanAddDeclTestCase); otherwise this appears to be working correctly.  Committed to CVS.

Kurt, could you please look at the disabled test case for Make Private Public?  Thanks.