Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 284288

Summary: UDC defaults to 60 second upload period if number formatted incorrectly
Product: [Technology] EPP Reporter: Wayne Beaton <wayne.beaton>
Component: Usage Data CollectorAssignee: Wayne Beaton <wayne.beaton>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: mknauer
Version: unspecifiedKeywords: plan
Target Milestone: 1.3.0   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
mylyn/context/zip none

Description Wayne Beaton CLA 2009-07-22 11:45:01 EDT
The UDC is designed to get it's settings from three locations. First, it looks for  a system property. Second, it looks for a stored preference. Finally, it takes a default value.

The UsageDataRecordingSettings#getPeriodBetweenUploads() method looks for a system property named org.eclipse.epp.usagedata.period. If the value specified cannot be converted into an int value, the "reasonable minimum" value takes over. The notion of a reasonable minimum was included to avoid allowing a naive user from setting the value too low. Unfortunately, the "reasonable minimum" value was set very low (60 seconds) for testing and was never reset to something that's actually reasonable (say, daily). Fortunately, this particular system property hasn't been advertised, so it's unlikely that this issue has arisen in the wild.
Comment 1 Wayne Beaton CLA 2009-10-08 14:49:16 EDT
Fixed and committed in HEAD. We will need a solution to make testing easier, but I'll defer that to a different bug.
Comment 2 Wayne Beaton CLA 2009-10-08 14:49:18 EDT
Created attachment 149158 [details]
mylyn/context/zip