Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 284154

Summary:

[performance] WikiText is causing a major slow down in task editor open

Product:

z_Archived

Reporter:

Mik Kersten <mik.kersten>

Component:

Mylyn

Assignee:

David Green <greensopinion>

Status:

RESOLVED DUPLICATE

QA Contact:

Severity:

major

Priority:

CC:

steffen.pingel

Version:

unspecified

Target Milestone:

1.1.2

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
profiling snapshot	none
calltree showing timings	none
profiler snapshot without wikitext	none
screenshot of calltree in profiler without wikitext	none

Description Mik Kersten

2009-07-21 12:24:51 EDT

I did some very quick and inconclusive benchmarking, and it looks like there is a 2-3x slow down in task editor open compared to having WikiText diabled.  I tried Confluence syntax with JIRA and Textile with Bugzilla, and both appeared to exhibit this.  We need to do additional performance profiling in order to determine where the bottleneck really is.   This is very high priority because task editor open time is a key point of friction that we have been working hard to minimize.

Comment 1 David Green

2009-08-03 01:27:42 EDT

Mik, thanks for the bug.  Can you point to a bug that causes the Mylyn task editor to exhibit this behaviour?

Comment 2 David Green

2009-08-12 20:42:10 EDT

Do you have a reliable way to measure the time it takes to open the task editor?

Comment 3 Steffen Pingel

2009-08-12 21:04:57 EDT

I don't have any good way of measuring that reliably. We should write performance tests for that to gather data that can be used to detect regressions.

Comment 4 David Green

2009-08-12 22:47:33 EDT

(In reply to comment #3)
> We should write  performance tests for that to gather data that can be used to detect regressions.

Agreed

Comment 5 David Green

2009-08-13 13:16:24 EDT

try testing bug with a long description, such as bug 280726

Comment 6 David Green

2009-08-13 13:24:09 EDT

possibly related, word wrap performance bug 168557

Comment 7 David Green

2009-08-24 12:28:38 EDT

I've done some profiling of opening the task editor.  The description part appears to account for about 10% of the total load time, of which only 4% can be attributed to WikiText.  I believe that recent changes to WikiText (fix for bug 283629) may have greatly reduced the delay when opening a task editor.

Comment 8 David Green

2009-08-24 12:29:56 EDT

Created attachment 145449 [details]
profiling snapshot

Attached profiler snapshot (NetBeans)

Comment 9 David Green

2009-08-24 12:33:48 EDT

Created attachment 145450 [details]
calltree showing timings

Comment 10 David Green

2009-08-24 12:37:56 EDT

Created attachment 145451 [details]
profiler snapshot without wikitext

Comment 11 David Green

2009-08-24 12:39:18 EDT

Created attachment 145452 [details]
screenshot of calltree in profiler without wikitext

Comment 12 David Green

2009-08-24 12:42:27 EDT

I've attached the snapshot and calltree with and without wikitext enabled, profiling opening of the same bug.  While it's not very useful to compare absolute times (milliseconds), it's interesting to compare relative times (percentages).

I suspect that this issue has largely been resolved by changes to WikiText with the fix for bug 283629.

Mik, any chance you could repeat your testing with the latest WikiText?  I recommend trying it out on a variety of bugs, including those that have large stack traces in the bug description.  As some of the performance figures will be platform-dependant (due to the use of SWT), it will be good to get your feedback from a Windows platform (my testing was done on a mac.)

Comment 13 David Green

2009-09-03 14:05:40 EDT

Fixed by bug 283629

*** This bug has been marked as a duplicate of bug 283629 ***