Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 283301

Summary:	OperationCanceledException should not be thrown
Product:	[Eclipse Project] PDE	Reporter:	Krzysztof Daniel <krzysztof.daniel>
Component:	API Tools	Assignee:	Michael Rennie <Michael_Rennie>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Michael_Rennie, Olivier_Thomann
Version:	3.5	Flags:	Olivier_Thomann: review+
Target Milestone:	3.6 M2
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Krzysztof Daniel

2009-07-13 07:38:17 EDT

I wanted to launch Eclipse and tired waiting for validation, cancelled it in Progress View.

Error Dialog has appeared:
'Validation' has encountered problem.

org.eclipse.core.runtime.OperationCancelledException.

In the .log you can find:
org.eclipse.core.runtime.OperationCanceledException
at org.eclipse.pde.api.tools.internal.util.Util.updateMonitor(Util.java:1047)
at org.eclipse.pde.api.tools.internal.builder.ApiAnalysisBuilder.build(ApiAnalysisBuilder.java:307)
at org.eclipse.core.internal.events.BuildManager$2.run(BuildManager.java:627)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:170)
at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:201)
at org.eclipse.core.internal.events.BuildManager$1.run(BuildManager.java:253)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:256)
at org.eclipse.core.internal.events.BuildManager.basicBuildLoop(BuildManager.java:309)
at org.eclipse.core.internal.events.BuildManager.build(BuildManager.java:341)
at org.eclipse.core.internal.resources.Workspace.build(Workspace.java:330)
at org.eclipse.wst.validation.internal.FullBuildJob.runInWorkspace(FullBuildJob.java:21)
at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:38)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

I believe that cancelling validation is not an error.

Comment 1 Michael Rennie

2009-08-07 15:22:34 EDT

The fix for this bug is included in the patch for bug 279286, due to overlapping code changes.

The problem was that we were incorrectly catching Exception in our compatibility checking code, which would trap and report the OperationCanceledException.

Comment 2 Michael Rennie

2009-08-12 14:00:18 EDT

applied fix with patch for 279286, please verify Olivier

Comment 3 Olivier Thomann

2009-09-18 09:36:32 EDT

Verified.