Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 283036

Summary: [Net] Nonfunctional button 'Restore Defaults' button on Network Connections preference page
Product: [Eclipse Project] Platform Reporter: Carlton Brown <carlton.brown>
Component: TeamAssignee: Platform Team Inbox <platform-team-inbox>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: aobuchow, daniel_megert, miwako.tokugawa, pawel.pogorzelski1, wojciech.galanciak
Version: 3.5Keywords: triaged
Target Milestone: ---Flags: wojciech.galanciak: review? (Szymon.Brandys)
Hardware: PC   
OS: Windows XP   
Whiteboard: stalebug
Bug Depends on:    
Bug Blocks: 548042    
Attachments:
Description Flags
partial patch
none
patch
none
patch none

Description Carlton Brown CLA 2009-07-09 11:20:29 EDT
Build ID: 20090619-0625

Steps To Reproduce:
1.  Go to 'Network Connections' screen in preferences
2.  Change a proxy port value in any proxy entry
3.  Click 'Restore defaults' and observe that nothing happens


More information:
It appears that the 'Restore Defaults' button does nothing but switch the active provider to 'Native'.
Comment 1 Pawel Pogorzelski CLA 2009-07-10 04:58:36 EDT
(In reply to comment #0)
> It appears that the 'Restore Defaults' button does nothing but switch the
> active provider to 'Native'.
 
Switching provider to 'Native' restores the default behavior. This is because entries for other providers are ignored and entries that correspond to 'Native' are controlled by OS (we can't do nothing more than scan them).

I'll add clearing entries for other providers after selecting 'Restore Defaults' to fully restore the default state.
Comment 2 Wojciech Galanciak CLA 2010-08-25 12:08:16 EDT
Created attachment 177437 [details]
partial patch

This patch works for proxy settings but not fully restores bypasses settings. The reason is that we do not know which bypass was added by user and which is default one. To avoid to hardcoding default values again and set them in preferences the better solution should be to use default preferences and just restore them when press on Restore Defaults button.
Comment 3 Wojciech Galanciak CLA 2010-09-16 12:29:03 EDT
Created attachment 179048 [details]
patch

patch provides full support for restore default settings.
Comment 4 Wojciech Galanciak CLA 2010-09-27 09:29:49 EDT
Current patch does not use default settings. Support for them will be provided in fix for bug 242057. If fix for bug 242057 is correct, I will provide new patch for 283036.
Comment 5 Wojciech Galanciak CLA 2010-10-18 06:53:34 EDT
Created attachment 181080 [details]
patch

This is a new patch which uses all features provided by fix for bug 242057.
Comment 6 Dani Megert CLA 2019-06-11 09:20:17 EDT
*** Bug 322036 has been marked as a duplicate of this bug. ***
Comment 7 Dani Megert CLA 2019-06-11 09:20:39 EDT
*** Bug 548114 has been marked as a duplicate of this bug. ***
Comment 8 Eclipse Genie CLA 2021-06-01 05:00:17 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.