Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 282924

Summary: [breakpoints][cdi] Breakpoint install marker not handled properly for multiple launches
Product: [Tools] CDT Reporter: Marc Khouzam <marc.khouzam>
Component: cdt-debug-dsf-gdbAssignee: Marc Khouzam <marc.khouzam>
Status: RESOLVED FIXED QA Contact: Marc Khouzam <marc.khouzam>
Severity: normal    
Priority: P3 CC: pawel.1.piech
Version: 6.0Flags: marc.khouzam: iplog-
marc.khouzam: review? (fchouinard)
Target Milestone: 7.0   
Hardware: PC   
OS: Linux   
Whiteboard:
Bug Depends on:    
Bug Blocks: 282925    
Attachments:
Description Flags
Fix none

Description Marc Khouzam CLA 2009-07-08 16:11:44 EDT 
The install marker (blue checkmark) indicates that a bp was installed in the backend.  When dealing with multiple launches, the same bp can be installed in different backends.  Currently, DSF-GDB assumes that when a launch is terminated, a bp is no longer installed.  This is not the case if another launch is using the same bp.

CDI handles this properly.

Care must be taken here to also consider the case of thread filters which require multiple installations of bp.
Comment 1 Marc Khouzam CLA 2009-07-10 14:36:09 EDT 
Created attachment 141326 [details]
Fix

This patch replaces our call to resetInstallCount() with the amount of calls to decrementInstallCount() that take care of the installation of the relevant launch.
Comment 2 Marc Khouzam CLA 2009-07-10 14:43:02 EDT 
Committed to 6.0.1 and 7.0
Francois can your review.