Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 282382

Summary: UDC: Upload url should be displayed in preferences/wizard
Product: [Technology] EPP Reporter: Michael Kuck <michael.kuck>
Component: Usage Data CollectorAssignee: Wayne Beaton <wayne.beaton>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: jonah, mknauer
Version: unspecifiedKeywords: plan
Target Milestone: 1.3.0   
Hardware: PC   
OS: Windows Vista   
Whiteboard:
Bug Depends on:    
Bug Blocks: 252259    
Attachments:
Description Flags
mylyn/context/zip none

Description Michael Kuck CLA 2009-07-03 10:28:50 EDT
Build ID: I20090611-1540

I know that the possibility to change the upload url via preferences was removed intentionally and I fully understand the reason why this has be done. There is only a small issue with this:

Let us assume a user is using an IDE with a modified upload url. Now for some reason the modified upload url is changed or removed or something like that, now the user will upload any statistics to the default url (which is eclipse) without ever noticing, at least if he does not look into the error log (which will be to late, too).

Now there are various solutions to this, including the following ones:
1. The upload url is being displayed in the preference page and/or wizard (as read only). 
2. A warning/popup should be displayed if the upload url has been changed (which normally should be fix). So if the modified url accidentally has been changed or removed, a warning should be displayed and the user can turn off uploading or something like that.

Kind regards,
Michael
Comment 1 Wayne Beaton CLA 2009-07-03 23:15:41 EDT
(In reply to comment #0)
> Now there are various solutions to this, including the following ones:
> 1. The upload url is being displayed in the preference page and/or wizard (as
> read only). 
> 2. A warning/popup should be displayed if the upload url has been changed
> (which normally should be fix). So if the modified url accidentally has been
> changed or removed, a warning should be displayed and the user can turn off
> uploading or something like that.


+1

These are good ideas. I believe that we should only show the dialog if the URL has changed since the last time an upload was attempted. Does that make sense? Are there other cases we need to consider?
Comment 2 Michael Kuck CLA 2009-07-06 12:14:41 EDT
(In reply to comment #1)
> (In reply to comment #0)
...
> 
> These are good ideas. I believe that we should only show the dialog if the URL
> has changed since the last time an upload was attempted. Does that make sense?
> Are there other cases we need to consider?
> 

I think that should make it. This way the user will not be bothered with this until something unexpected happens. 

But we should think about what will be displayed in the popup?
Something like this would be easy to implement: "the usage data collector upload url was modified unexpectedly, do you want to turn uploading off?" Does it make sense to display the new and the old url? Maybe, I do not know :-)

Michael


Comment 3 Michael Kuck CLA 2009-07-27 10:54:35 EDT
Another thought:
Currently, in the upload wizard, it says:
"[...] would now like to upload the data to a server at the Eclipse Foundation."
That is obviously not correct as soon as somebody changes the upload url. Maybe this text should be changed along with the system property.
I have 4 possible solutions in mind:

1. Make the text more general
2. Change the text to display the upload url instead. this way the user could have a look at the domain name. As stated before, somewhere the url should be displayed anyway (as read only).
3. Another system property to display this specific string
4. Extend the current system property to include the string and the upload url (which would require more magic in parsing the property

Personally I would favor 2. or 3.

Kind regards,
Michael Kuck
Comment 4 Wayne Beaton CLA 2010-02-18 14:49:00 EST
I've split this bug in two. I'll address the display of the URL in the preferences/wizard here; I've moved explicitly warning the user of the change to Bug 303229.

I've commited code to display the upload URL on the preferences page.

I'm still thinking about how I want to implement this on the upload wizard. I'm considering parameterizing "the Eclipse Foundation" out of the blurb at the top. If the Upload url in the settings is the same as the default, then I'll display "The Eclipse Foundation". Otherwise, I'll display the actual URL. May consider options 3&4 above to display an actual useful string.
Comment 5 Wayne Beaton CLA 2010-02-18 14:49:23 EST
Created attachment 159475 [details]
mylyn/context/zip
Comment 6 Jonah Graham CLA 2021-05-07 10:23:43 EDT
The Usage Data Collector was decommissioned a long time ago. Therefore any
remaining bugs are now being closed as WONTFIX. If this bug is still relevant,
please make a comment and we'll move it to the correct project/component for
further investigation.

This change was made as part of a bulk change.