Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 281898

Summary:	[Spinner] Spinner falsely respects SWT.FLAT
Product:	[RT] RAP	Reporter:	Ralf Sternberg <rsternberg>
Component:	RWT	Assignee:	Project Inbox <rap-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	asen, ivan
Version:	1.2
Target Milestone:	1.3 M1
Hardware:	All
OS:	All
Whiteboard:

Description Ralf Sternberg

2009-06-29 15:44:49 EDT

In SWT, the style flag FLAT is only applicable to Button and ToolBar. Consequently, Spinner must not respect this style flag.
See appearance "spinner-button" in AppearancesBase.js.

I think, we should also remove FLAT from ControlLCAUtil#writeStyleFlags, because it only needs to be written for Buttons and ToolBars/ToolItems. This would leave this method with one style flag (BORDER) to write, so it should be inlined.

Comment 1 Asen Draganov

2009-07-08 10:08:49 EDT

The client side of the Spinner currently doesn't respect the FLAT flag, despite it could be provided from the server. This behavior is a fact, after the patch from bug 281770 (https://bugs.eclipse.org/bugs/show_bug.cgi?id=281770) has been applied.
Apart from the mentioned Button and Toolbar, the CCombo widget also respects the FLAT flag.

Comment 2 Ivan Furnadjiev

2009-09-01 05:30:00 EDT

Fixed with bug 281770.