Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 281787

Summary: Bundle image resources exposed under changing context
Product: [RT] RAP Reporter: Paul Kendall <pkendall64>
Component: JFaceAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ruediger.herrmann, vasko, webmaster
Version: 1.2   
Target Milestone: 1.3 M2   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Patch the prepends "bundle/" to the generated URL
none
Proposed fix
none
Proposed fix
none
Proposed fix none

Description Paul Kendall CLA 2009-06-28 19:07:12 EDT 
Created attachment 140325 [details]
Patch the prepends "bundle/" to the generated URL

Build ID: 1.2.0

Steps To Reproduce:
Image resources that are registered with AbstractUIPlugin.imageDescriptorFromPlugin are exposed via a context which uses toString on the URL which creates a path that is not under a useful context. An example URL is as follows.

http://localhost:8080/52.fwk1469937134/images/logo_large.png

More information:
Our application is deployed with tomcat and the IIS ISAPI redirector is used to forward know contexts to the tomcat instance.

A patch is attached that prepends "bundle/" to the generated URL so all images registered this way are under a /bundle context. This allows us to forward all known contexts to the tomcat instance via the redirector.
Comment 1 Rüdiger Herrmann CLA 2009-08-19 09:41:38 EDT 
Created attachment 144956 [details]
Proposed fix

This patch solves the problem in RWT. The resource manager now prepends a "resource" segment to the path of a resource.
Comment 2 Rüdiger Herrmann CLA 2009-08-25 06:35:04 EDT 
Applied patch to CVS HEAD.
Comment 3 Rüdiger Herrmann CLA 2009-08-26 06:02:37 EDT 
The patch prevents images from being displayed.
Changes are reverted.
Comment 4 Markus Krüger CLA 2009-08-26 06:21:58 EDT 
Just wanted to open a bug, as I couldn't see images. But your revert in CVS helped. Now everthing is correct again, at least for me.
Comment 5 Rüdiger Herrmann CLA 2009-08-28 09:27:32 EDT 
Created attachment 145933 [details]
Proposed fix
Comment 6 Rüdiger Herrmann CLA 2009-08-28 09:57:26 EDT 
Created attachment 145938 [details]
Proposed fix

Slightly improved version of hte previous proposal
Comment 7 Rüdiger Herrmann CLA 2009-08-28 10:06:33 EDT 
Applied fourth patch to CVS HEAD
Comment 8 Markus Krüger CLA 2009-08-31 08:23:43 EDT 
Our images are now gone everywhere!

Analyzing it with firebug:
Toolbar points to image: url(./resources/resource/static/image/blank.gif)
And for example a image for a button points to: url(http://127.0.0.1:8181/resources/46.fwk1035988/icons/full/elcl16/plus_act.gif)

Both urls do not show the image.

In RAP demo it seems to work.

Is there now some new requirement for registering images to be shown?

Regards,
Markus
Comment 9 Rüdiger Herrmann CLA 2009-08-31 09:52:47 EDT 
(In reply to comment #8)
> Our images are now gone everywhere!
> 
[ ... ]

I cannot reproduce what you describe. Recently there was a "redirect servlet" introduced, that made it into the org.eclipse.rap.examples plug-in. Does your launch config reference this plug-in? Or does your application register a servlet for alias "/"?

Please open a separate bug report if you have code or a step-by-step guide to reproduce the problem.
Comment 10 Markus Krüger CLA 2009-08-31 10:05:29 EDT 
Ok, i figured out the problem with your hint.
We integrated eclipse help like in the plugin "Help integration".
Now either I have working images or I have a working help.
Both together now do not work anymore, which is tragic, as we need both since we do not want to develope our own help system.
The help system registers at "/", but it does not seem to be changeable easyly as it looks loke all subpages of the help depend on it, or at least some of them.

So this is not good for us!
Comment 11 Markus Krüger CLA 2009-09-01 05:42:50 EDT 
Do you plan on making it compatible or remove the fix to get help working again?
Comment 12 Rüdiger Herrmann CLA 2009-09-01 05:54:43 EDT 
(In reply to comment #11)
> Do you plan on making it compatible or remove the fix to get help working
> again?
We currently investigatong, with a different use case (a redirect servlet) but cannot reliably reproduce the wrong behaviour.
We are not convinced that this change causes the missing images. In the meanwhile you can revert the patch for yourself. (apply path -> reverse patch check box) Please let us know whether your problem persists after reverting the changes.
Comment 13 Markus Krüger CLA 2009-09-01 06:10:39 EDT 
Cool, did not know that you can revert a patch since there is no direct menu entry for it, just applay patch.

Anyways, after reverting the path the images are visible and help also works.
So it is this change that causes the problem.
Comment 14 Markus Krüger CLA 2009-09-03 06:36:49 EDT 
Are you further invastigating? Or can you reproduce the problem adding "Help integration" to RAP Demo?
Shouldn't you revert this patch in CVS until problems with "Help integration" are solved and reopen this bug, or should someone open a new bug on this problem?
Comment 15 Rüdiger Herrmann CLA 2009-09-07 08:55:41 EDT 
(In reply to comment #14)
> Are you further invastigating? Or can you reproduce the problem adding "Help
> integration" to RAP Demo?
The problems with "Help integration" are solved now Changes are in CVS HEAD.

> Shouldn't you revert this patch in CVS until problems with "Help integration"
> are solved and reopen this bug, or should someone open a new bug on this
> problem?
Comment 16 Markus Krüger CLA 2009-09-07 09:22:38 EDT 
Cool, need to check it right away. Was there a change now in "Help Integration" or somewhere else in RAP Plugins?
Comment 17 Markus Krüger CLA 2009-09-07 10:02:53 EDT 
OK, seems that there was only one change in one class.
Everything looks good now.
Thank you for fixing this. Good work.