Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 281650

Summary:

Bug with translation of the "description" property

Product:

[RT] RAP

Reporter:

Igor Pavlenko <dopperst>

Component:

Workbench

Assignee:

Project Inbox <rap-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

1.2

Target Milestone:

1.3 M1

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Path to fix the bug	none
Extensions page in plugin.xml editor	none
Wizard without patch	none
Wizard with patch	none
Wizards description value in plugin.xml value	none

Description Igor Pavlenko

2009-06-26 08:33:25 EDT

I use an org.eclipse.rap.equinox.registry patch-fragment and I have a problem with translation. I use a description property an I have some text there (%demoWizardDescription).

This property does not become localized and shows as is (For example on the "Select a wizard")

Comment 1 Igor Pavlenko

2009-06-26 08:40:42 EDT

Created attachment 140218 [details]
Path to fix the bug

Look a the org.eclipse.core.internal.registry.ConfigurationElement from org.eclipse.rap.equinox.registry patch-fragment.

Look at the ConfigurationElement#getAttribute(String) method. It is reimplemented to support localization on demand.

Look at the ConfigurationElement#getValue() method. I think it also should be reimplemented (as in my patch).

It is important, for example, for the org.eclipse.ui.internal.dialogs.WorkbenchWizardElement.getDescription() method (it use the "description" property)

Comment 2 Benjamin Muskalla

2009-07-22 09:52:46 EDT

Igor, thanks for the patch.
But I still didn't get the point what "description" you're refering to. Can you give me a concrete example where the current implemention fails? I'd really like to get these fixes in - just want to be sure for what they're for ;-)

Comment 3 Igor Pavlenko

2009-07-22 22:41:09 EDT

Created attachment 142338 [details]
Extensions page in plugin.xml editor

Comment 4 Igor Pavlenko

2009-07-22 22:42:20 EDT

Created attachment 142339 [details]
Wizard without patch

Comment 5 Igor Pavlenko

2009-07-22 22:42:52 EDT

Created attachment 142340 [details]
Wizard with patch

Comment 6 Igor Pavlenko

2009-07-22 22:43:52 EDT

Created attachment 142341 [details]
Wizards description value in plugin.xml value

Comment 7 Igor Pavlenko

2009-07-22 22:44:55 EDT

Look at the attached images for details

Comment 8 Benjamin Muskalla

2009-07-24 05:05:58 EDT

Great, thanks Igor! Will take a look at this during M1.

Comment 9 Benjamin Muskalla

2009-08-10 03:38:29 EDT

Thanks for the patch Igor. Applied to CVS HEAD with some minor modifications (added comment).