Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 281289

Summary:

JobManagerAdapter hanging onto old jobs

Product:

[RT] RAP

Reporter:

Ian Bull <irbull>

Component:

Workbench

Assignee:

Project Inbox <rap-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

b.muskalla, loic.bertholet, philippe.nembrard

Version:

unspecified

Target Milestone:

1.3 M2

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Proposed fix	none

Description Ian Bull

2009-06-23 18:51:43 EDT

The list of job referenced by the JobManagerAdapter is hanging onto too many jobs.  The only way elements are removed from this list is (on line 120):
        if( !job.shouldSchedule() ) {
          jobs.remove( job );
        }
        
However, the default implementation of shouldSchedule() returns true, so unless a client specifically overrides shoudlSchedule, the job will never be removed from this list.

Comment 1 Rüdiger Herrmann

2009-06-24 06:09:01 EDT

Created attachment 139968 [details]
Proposed fix

Removes the if( !job.shouldSchedule() )
I cant find a reason why this if statement was necessary in the first place, however I am uncertaint about possible side effects.

Comment 2 Ian Bull

2009-07-10 14:25:30 EDT

*** Bug 274017 has been marked as a duplicate of this bug. ***

Comment 3 Rüdiger Herrmann

2009-08-28 10:31:48 EDT

Applied patch to CVS HEAD