Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 281114

Summary:

Workbench leaks WorkingSetManager

Product:

[RT] RAP

Reporter:

Benjamin Muskalla <b.muskalla>

Component:

Workbench

Assignee:

Project Inbox <rap-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

major

Priority:

CC:

irbull

Version:

1.2

Target Milestone:

1.3 M1

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
patch	none

Description Benjamin Muskalla

2009-06-22 13:14:21 EDT

Currently the WorkingSetManager is created and adds itself as BundleListener (AbstractWorkingSetManager#ctor) and is cleaned up properly on dispose.
Problem is that we have a session-aware WorkingSetManager but the dispose call is still located in the bundle stop method.
The dispose call should be moved to the ShutdownHandler - else we end up having one WorkingSetManager in the ListenerList of the BundleContext for each session.

Comment 1 Benjamin Muskalla

2009-06-22 13:18:45 EDT

Created attachment 139778 [details]
patch

Patch moves the corresponding code to the ShutdownHandler

Comment 2 Benjamin Muskalla

2009-08-07 07:02:06 EDT

Fixed in CVS with the attached patch and small modification in WorkbenchPlugin: super.stop is not commented out.