Bugzilla – Full Text Bug Listing
| Summary: | SWTException during TableDataEditor save. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] Data Tools | Reporter: | Ivar Meikas <ivar> | ||||
| Component: | Table Data Editor | Assignee: | Brian Payton <bpayton> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | ahti, bpayton, fulghum, hinaba | ||||
| Version: | unspecified | ||||||
| Target Milestone: | 1.7.2 | ||||||
| Hardware: | PC | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Hi Quy, can you evaluate the patch from Ivar? Hi Brian, The patch looks fine. Hi, is this patch committed to HEAD or maybe even already released? Any update on this? Any idea when this might make it into a future release? Hi Brian, Can you commit the patch? I have already reviewed it. Thanks. I applied the patch to the HEAD (1.7.2 and 1.8) code stream. Tagged to v200912080845. Also updated the plugin version to 1.1.2.qualifier. Forgot to mark this as fixed. |
Created attachment 138777 [details] TableDataEditor patch In TableDataEditor, when you create rows, change values there, remove the row and then save the editor, org.eclipse.swt.SWTException: Widget is disposed is thrown. The problem lies in the doDelete() method, that doesn't remove dirty TableItems from internal set, and during save, call to revertToOriginalBackground() accesses a disposed TableItem. I created a patch that will fix the issue.