| Summary: | [Import/Export] Recursive addition problem in Import > Existing projects into workspace | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | mkaditya <amadduri> | ||||||
| Component: | IDE | Assignee: | Prakash Rangaraj <prakash> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | Prakash Rangaraj <prakash> | ||||||
| Severity: | major | ||||||||
| Priority: | P3 | CC: | daniel_megert, freidin.alex, glasskarma, john-michael.au, prakash.narayana, remy.suen | ||||||
| Version: | 3.4.2 | ||||||||
| Target Milestone: | 3.7 M4 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
mkaditya
(In reply to comment #0) > Build ID: M20090211-1700 > > Steps To Reproduce: > 1. Create Workspace ws1 > 2. Create project p1. do you exit here and then restart eclipse with ws1/p1? > 3. Create Workspace ws1/p1 > 4. One Import > Existing projects into workspace > 5. Select ws1/p1 and check the option "Copy projects into workspace". Which file location do you select to import from? ws1? PW (In reply to comment #1) > (In reply to comment #0) > > Build ID: M20090211-1700 > > > > Steps To Reproduce: > > 1. Create Workspace ws1 > > 2. Create project p1. > > do you exit here and then restart eclipse with ws1/p1? Yes. > > > 3. Create Workspace ws1/p1 > > 4. One Import > Existing projects into workspace > > 5. Select ws1/p1 and check the option "Copy projects into workspace". > > Which file location do you select to import from? ws1? I will import ws1/p1 (project). > > PW > (In reply to comment #2) > > Which file location do you select to import from? ws1? > I will import ws1/p1 (project). When I open File>Import>Existing... it asks for a Root location ... what is it? PW (In reply to comment #3) > (In reply to comment #2) > > > Which file location do you select to import from? ws1? > > I will import ws1/p1 (project). > > When I open File>Import>Existing... it asks for a Root location ... what is it? It should be ws1/p1. (please note that p1 is project as well as the present workspace). > > PW > Created attachment 138801 [details]
Import dialog
I cannot reproduce. If I select as shown here, clicking OK opens an error dialog complaining about overlapping workspace locations.
This is on an RC build I20090603-2000 for 3.5.
PW
This might have been fixed by work in 3.5 PW (In reply to comment #6) > This might have been fixed by work in 3.5 > PW > I checked in 3.5 RC4 and I found that problem is still there. Following are the exact steps I have done. 1) Create a workspace D:\rws. 2) Create a java project p1. 3) Close the workspace. 4) Now launch the eclipse with workspace as D:\rws\p1. 5) Right click in the package explorer and select the import option. 6) Choose 'Existing Projects into Workspace' option from the Import wizard. 7) In select root directory choose D:\rws\p1 8) Check the option 'Copy projects into workspace'. 9) Click finish and find the recursive problem. Same on 3.5 RC4. Paul, the key is to change the change workspace location in step 3. Which in my opinion is not a very common scenario. Fix is to check the URL using ResourcesPlugin.getWorkspace().validateProjectLocationURI(project, locationURI); in line 1368 of WizardProjectsImportPage.createExistingProject(ProjectRecord, IProgressMonitor) The problem still reproducible in 3.5 release. It is important to mark the 'Copy projects into workspace' checkbox. The attached screenshot has it unmarked. This bug is still there in 3.6 M6. I made a patch based on comment 8. Hopefully, we get this closed before 3.6 release. Created attachment 167617 [details]
Checks for overlapping workspace/project location
*** Bug 314617 has been marked as a duplicate of this bug. *** Patch released to HEAD. Thanks Alex *** Bug 227443 has been marked as a duplicate of this bug. *** Verified in I20101206-1800 *** Bug 348037 has been marked as a duplicate of this bug. *** |