Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 279460

Summary: [TableViewer] Scrolling problem when turning on editing support
Product: [RT] RAP Reporter: Björn Fischer <b.fischer>
Component: JFaceAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 1.2   
Target Milestone: 1.3 M1   
Hardware: All   
OS: All   
Whiteboard: qx-closed
Bug Depends on:    
Bug Blocks: 273397    
Attachments:
Description Flags
Screenshot showing the described scrolling bug
none
prevents unwanted native scrolling of Table
none
new version proposed to qooxdoo developers
none
uses "disableScrolling" on Table none

Description Björn Fischer CLA 2009-06-08 09:23:33 EDT
There is a problem with the scrolling on TableViewers that have editing support with CellEditors turned on.

Steps to reproduce:
1. Open the contols demo, tab "TableViewer".
2. Select Button "Create cell editor".
3. Move the sash to the left until only the two columns "First Name" and "Last Name" are visible.
4. Click into the first column of an editable person (e.g. "Albert") to make it editable.
5. Push the Tab button until the cursor moves to the third (invisible) column. The Cursor disapperars, but no scrolling happens at all (part 1 of the bug).
6. Again click into the first column of the selected person to make it editable.
7. Push the Tab button until the cursor moves to the third column. This time there does happen scrolling, but not like it should. Instead of scrolling only the horizontal scrollbar, the whole viewer is moved to the left (part 2 of the bug, see attached screenshot).

All in all the whole editing support seems a little buggy in RAP (editors not getting activated on first click - have to click twice, field selection not jumping to the next field on first tab and so on).
Comment 1 Björn Fischer CLA 2009-06-08 09:25:05 EDT
Created attachment 138566 [details]
Screenshot showing the described scrolling bug
Comment 2 Rüdiger Herrmann CLA 2009-06-09 08:21:42 EDT
After a first quick investigation, it looks like this is caused by this qooxdoo bug:
  368: Focussing item out of the clipping area breaks layout
  http://bugzilla.qooxdoo.org/show_bug.cgi?id=368
Comment 3 Tim Buschtoens CLA 2009-06-12 09:11:40 EDT
Created attachment 139020 [details]
prevents unwanted native scrolling of Table

This patch adds a function to WidgetUtil that can be used to disable browser-native scrolling of Widget-content. This function is then used in the constructor of org.eclipse.swt.widgets.Table. In Firefox there may be a slight flicker visible when the browser attempts to scroll.
Comment 4 Tim Buschtoens CLA 2009-06-24 06:41:16 EDT
Created attachment 139972 [details]
new version proposed to qooxdoo developers

disableScrolling can now be found in qx.ui.core.Widget instead of WidgetUtil
Comment 5 Tim Buschtoens CLA 2009-06-24 06:44:33 EDT
Created attachment 139973 [details]
uses "disableScrolling" on Table

to be used with Attachment 139972 [details]
Comment 6 Ivan Furnadjiev CLA 2009-07-08 09:33:16 EDT
Applied the patches to CVS HEAD.