Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 279334

Summary: make the bugzilla keywords attribute editor usable by other connectors
Product: z_Archived Reporter: Shawn Minto <shawn.minto>
Component: MylynAssignee: Shawn Minto <shawn.minto>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: steffen.pingel
Version: unspecified   
Target Milestone: 3.3   
Hardware: PC   
OS: Windows Vista   
Whiteboard:
Bug Depends on: 287832    
Bug Blocks:    
Attachments:
Description Flags
patch
none
mylyn/context/zip
none
updated patch
none
Here's a version with better layout
none
mylyn/context/zip none

Description Shawn Minto CLA 2009-06-05 19:35:11 EDT 
It would be nice to be able to reuse the keywords attribute editor for other attributes
Comment 1 Shawn Minto CLA 2009-06-05 19:38:29 EDT 
Created attachment 138459 [details]
patch

Here is a patch that we could start with to make this generic
Comment 2 Shawn Minto CLA 2009-08-27 18:06:08 EDT 
I have added a CheckBoxTreeDialog to the provisional commons for use by clients.  Also, I added a CheckBoxMultiSelectAttribiteEditor that encapsulates the use of this dialog and a text field.  The BugzillaKeywordAttributeEditor now extends the CheckBoxMultiSelectAttribiteEditor.  The KeywordsDialog in Bugzilla is still used in the search page and I have created bug 287899 to use the common dialog instead.
Comment 3 Shawn Minto CLA 2009-08-27 18:06:11 EDT 
Created attachment 145867 [details]
mylyn/context/zip
Comment 4 Shawn Minto CLA 2009-08-27 18:06:29 EDT 
Created attachment 145869 [details]
updated patch
Comment 5 Shawn Minto CLA 2009-08-27 18:06:47 EDT 
commited.
Comment 6 Pawel Niewiadomski CLA 2009-09-02 06:22:02 EDT 
Created attachment 146268 [details]
Here's a version with better layout

Seems long text is cut off in this Attribute Editor. Added code to layout again whole section (and the Attribute Editor) - this makes it resize nicely.
Comment 7 Shawn Minto CLA 2009-09-02 11:18:22 EDT 
Pawel, can you create a new bug for the wrapping issue and attach the patch and context for the patch there?
Comment 8 Steffen Pingel CLA 2009-09-17 16:47:01 EDT 
Notes from today's call:
* Replace Edit button by icon since the "Edit" label could get long in other languages.
* Remove trailing colon in dialog title.

Shawn, I have addressed the two points above. I'll reopen so you can turn the dialog into a popup-style shell.
Comment 9 Shawn Minto CLA 2009-09-17 18:24:29 EDT 
Should we have a new bug for that since it is related to other similar dialogs (i.e. date picker)?
Comment 10 Steffen Pingel CLA 2009-09-17 18:37:02 EDT 
Yes, makes sense, this is also related to bug 286286.
Comment 11 Steffen Pingel CLA 2009-10-07 18:08:48 EDT 
I just noticed that the CheckboxMultiSelectAttributeEditor editor does not respect the read-only flag. Shawn, can you add that and just render it as a comma separated list in a text field without a border (see SingleSelectionAttributeEditor). Looks like MultiSelectAttributeEditor has the same limitation and should be fixed as well.
Comment 12 Shawn Minto CLA 2009-10-07 18:30:18 EDT 
Good find.  I have made these editors have a readonly mode now like the SingleSelectionAttributeEditor does.
Comment 13 Shawn Minto CLA 2009-10-07 18:30:23 EDT 
Created attachment 149063 [details]
mylyn/context/zip