Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 279133

Summary:

[Design] Design disregards ISaveable implementation and dirty flag for views

Product:

[RT] RAP

Reporter:

Hasan Ceylan <hceylan>

Component:

RWT

Assignee:

Project Inbox <rap-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

unspecified

Target Milestone:

1.2

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Enablement for view's dirty state	none

Description Hasan Ceylan

2009-06-04 12:36:56 EDT

Build ID: Head

Steps To Reproduce:
We have a workbench application that we rely on views to do the data entry & modification.

It seams like, new design disregards dirty flag and savable implementation.

I do not have information for the editors as we do not use generic editors.

1) WB observes each and every views dirty state.
2) If a views dirty state is set to true, a feed back (usually a star) is appended to the view's title.
3) When a view or the workbench al together is requested to be closed, workbench visits each and every view that has the dirty flag set to true and prompts user if he/she wants to save. If the workbench is being shutdown, prompt displays all the dirty views and editors and a single prompt prompts for all the resources once.

4) A failure during the save call (An excpetion thrown), halts the view's closing (or further save implementation for the remaining views, in case for WB shutdown)  and error is displayed with generalized ErrorDialog. 

5) if save is successful views is let close.
6) If WB is being shutdown, if all the views are successfully saved, the WB is let shutdown.

More information:
Design should follow classical WB save handling based on the above information...

This works well with unthemed workbench applications.

Regards,
Hasan Ceylan

Comment 1 Rüdiger Herrmann

2009-06-05 09:43:56 EDT

So far, I can only confirm that the design does not indicate the dirty state in the view title.

Comment 2 Holger Staudacher

2009-06-11 11:05:42 EDT

Created attachment 138940 [details]
Enablement for view's dirty state

The attached patched enables the view's dirty state and disable the closing of the view if the save dialog is not closed via yes or no.

Comment 3 Rüdiger Herrmann

2009-06-12 06:18:52 EDT

+1 for the patch

Comment 4 Holger Staudacher

2009-06-13 03:45:09 EDT

committed.

Comment 5 Hasan Ceylan

2009-06-15 12:16:39 EDT

I can confirm that the issue has been resolved.

Thanks for the time and efforts...

Hasan