Bugzilla – Full Text Bug Listing
| Summary: | GraphModelFactory doesn't create nodes with custom figures | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] GEF | Reporter: | Tiago Proenca <tproenca> | ||||||
| Component: | GEF-Legacy Zest | Assignee: | Ian Bull <irbull> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | irbull | ||||||
| Version: | 3.4 | ||||||||
| Target Milestone: | 3.6.0 (Helios) RC1 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Created attachment 162004 [details]
updated patch
The patch is stale. This is an updated version. I want to test this a bit more, so I will apply it for M7.
We released 3.6 M7 today so moving unresolved bugs to 3.6 RC1. We need to re-access if we can complete these for Helios. I've tested the patch a bit more and I'm happy with it. Released to head. |
Created attachment 137812 [details] Patch for AbstractStylingModelFactory.createConnection() In the method doBuildGraph(), if the source or dest objects are null, it just creates the nodes instances, using a custom figure if available. However, if source or dest are different from null, it calls directly AbstractStylingModelFactory.createConnection() which doesn't verify the existence of custom figures. Basically, custom figures doesn't work when you use a IGraphContentProvider. Attached is a patch with the fix in AbstractStylingModelFactory.createConnection() method to consider custom figures.