Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 278361

Summary: [Combo] Overlays text after changing items
Product: [RT] RAP Reporter: Markus Krüger <webmaster>
Component: RWTAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: critical    
Priority: P3 CC: ivan
Version: 1.2   
Target Milestone: 1.2 RC3   
Hardware: All   
OS: All   
Whiteboard: qx-open
Attachments:
Description Flags
Overlayed combo text
none
Snippet in create part control
none
Proposed patch.
none
Proposed patch.
none
Proposed patch. ivan: review?

Description Markus Krüger CLA 2009-05-29 06:23:37 EDT 
Since some update (we are working with CVS version) the Combo overlays text of items if you change the items in the combo, i.e. remove all and add new items.
The text of the old items is still there and the text of the new items is writter over the old text.
I attached an image where see the overlay and a snippet to reproduce it.
Just adde the snippet to a view's createControl method or so.
This causes our application to not be useable anymore!
Comment 1 Markus Krüger CLA 2009-05-29 06:24:22 EDT 
Created attachment 137620 [details]
Overlayed combo text
Comment 2 Markus Krüger CLA 2009-05-29 06:25:43 EDT 
Created attachment 137621 [details]
Snippet in create part control
Comment 3 Ivan Furnadjiev CLA 2009-05-29 08:00:34 EDT 
Created attachment 137629 [details]
Proposed patch.

List tems are not removed from DOM if the display property is false.
Please review.
Comment 4 Markus Krüger CLA 2009-05-29 08:19:10 EDT 
Works like a charm with this patch.
Comment 5 Rüdiger Herrmann CLA 2009-05-29 09:16:42 EDT 
Ivan,
Could that also be solved in the qx ListItem.js? 
I thought setting the displayable field to true as it is done in the Tree would solve the issue.
Comment 6 Ivan Furnadjiev CLA 2009-05-29 10:34:10 EDT 
Created attachment 137649 [details]
Proposed patch.

A new version of the patch that does not touch inner list "display" property.
Comment 7 Ivan Furnadjiev CLA 2009-05-29 15:58:58 EDT 
Opened qooxdoo bug:
Removing child from hidden parent leads to broken appearance and memory leak
http://bugzilla.qooxdoo.org/show_bug.cgi?id=2444
Comment 8 Markus Krüger CLA 2009-06-02 05:06:45 EDT 
Last patch worked for me, too.
Comment 9 Ivan Furnadjiev CLA 2009-06-02 05:10:26 EDT 
Created attachment 137972 [details]
Proposed patch.

Small code rafactorings.
Comment 10 Ivan Furnadjiev CLA 2009-06-02 05:12:36 EDT 
Changes are in CVS HEAD.