Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 278346

Summary:

[List] Javascript error when removing selected items

Product:

[RT] RAP

Reporter:

Ralf Sternberg <rsternberg>

Component:

RWT

Assignee:

Project Inbox <rap-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

critical

Priority:

Version:

1.2

Target Milestone:

1.2 RC3

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Proposed patch.	none
Proposed patch with test case.	none
Proposed patch with test case.	rsternberg: review+

Description Ralf Sternberg

2009-05-29 04:48:49 EDT

Steps to reproduce:

* Use a List with MULTI style
* Add five items
* Select all items
* Remove selected items using List#remove()

-> Javascript error in occures in Firefox: "TypeError: vItem is undefined"

Use snippet from bug 278344 to reproduce.

Comment 1 Ivan Furnadjiev

2009-05-29 09:12:45 EDT

Created attachment 137635 [details]
Proposed patch.

The selected indices were not adjusted after selected item removal.
This patch solves bug 278344 as well.
Please review.

Comment 2 Ivan Furnadjiev

2009-05-29 10:56:47 EDT

Created attachment 137652 [details]
Proposed patch with test case.

Test case added to previous patch.

Comment 3 Ivan Furnadjiev

2009-05-29 11:40:13 EDT

Created attachment 137666 [details]
Proposed patch with test case.

Some code refactorings of the previous patch.

Comment 4 Ralf Sternberg

2009-05-29 17:21:56 EDT

Comment on attachment 137666 [details]
Proposed patch with test case.

I agree to commit this patch.

Comment 5 Ivan Furnadjiev

2009-06-02 05:17:55 EDT

Changes are in CVS HEAD.