Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 278123

Summary:	improve supportability of org.eclipse.jst.jsp.core JSPTokenizer
Product:	[WebTools] WTP Source Editing	Reporter:	Troy Bishop <tjbishop>
Component:	jst.jsp	Assignee:	jst.jsp <jst.jsp-inbox>
Status:	RESOLVED DUPLICATE	QA Contact:	Nitin Dahyabhai <thatnitind>
Severity:	normal
Priority:	P3	CC:	david_williams
Version:	3.0.3
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Troy Bishop

2009-05-27 16:20:06 EDT

Build ID: WTP 3.0

Steps To Reproduce:
Our adopter product has support for allowing customers to send in their .log entries so that we can see where problems are occurring during real usage.  The following error report was sent many times ( > 100000 ) over the past month but it does not provide any sort of meaningful information:

!ENTRY org.eclipse.jst.jsp.core 4 4
!MESSAGE Error: could not match input

This log entry is not very useful from a supportability perspective as it does not provide any content.  Is there anything that could be done to help in terms of describing what input could not be matched?  It looks like this error is happening in org.eclipse.jst.jsp.core.internal.parser.internal.JSPTokenizer#primGetNextToken as this is the only place that I think this specific log entry could be added (and I don't even want to begin to try and understand the logic in this method ;) but if any additional information can be added, such as "input 'xyz' was expected but received 'abc' in file WebProject/my.jsp" then I think it would be a bit more helpful in terms of determining why this error is happening (i.e. is it a bug in the jsp itself or a bug in the jsptokenizer code)

More information:

If you don't feel that additional information can be added to the log file then please consider removing the entry from the .log file as I don't see any value that it is adding and it is just "polluting" the .log file (but please correct me if I am wrong).

Comment 1 David Williams

2009-07-23 23:31:05 EDT

Just to cross-reference, see bug 284441.

Comment 2 David Williams

2009-08-05 04:26:25 EDT

I'm going to resolve this as a dup of bug 284441. 

There is, sort of, a separate issue of "using care to be sure there's never thousands of messages written to the logs" ... but, since there's a work around for this particular case, I'd suggest general code logging improvements be handled as another new feature enhancements ... if someone wants to work on that. 

Thanks, 




*** This bug has been marked as a duplicate of bug 284441 ***