Bugzilla – Full Text Bug Listing
| Summary: | [BlockSelection] Block Selection is not BIDI aware | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Felipe Heidrich <eclipse.felipe> |
| Component: | SWT | Assignee: | Platform-SWT-Inbox <platform-swt-inbox> |
| Status: | CLOSED WONTFIX | QA Contact: | Felipe Heidrich <eclipse.felipe> |
| Severity: | normal | ||
| Priority: | P3 | CC: | daniel_megert, eclipse, gheorghe, Lina.Kemmel, matial, Mike_Wilson, Silenio_Quarti, snorthov |
| Version: | 3.5 | Keywords: | triaged |
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows Vista | ||
| Whiteboard: | stalebug | ||
|
Description
Felipe Heidrich
Your bug has been moved to triage, visit http://www.eclipse.org/swt/triage.php for more info. I think this is an excellent opportunity to implement visual selection in StyledText. Visual selection is concerned with text *visually displayed* between the start and end selection points (as opposed to logical selection dealing with the *buffer* content between the logical positions of the start and end points). Visual selection is more intuitive and is preferred by some Bidi users to the logical selection. Guidelines on visual selection are available as part of "Guidelines of a Logical User Interface for Editing Bidirectional Text" written by Mati Allouche at: http://www.qsm.co.il/Hebrew/logicUI22.htm#h1-22 (Mati: perhaps you can point to a newer version of this document?) In StyledText, I currently see the following non-public methods that would be affected: - int insertBlockSelectionText(String text, boolean fillWithSpaces) - void insertBlockSelectionText(char key, int action) - String getBlockSelectionText(String delimiter) (In reply to comment #2) > I think this is an excellent opportunity to implement visual selection in > StyledText. Disagree. To implement visual selection will you need (at least): Add MOVEMENT_CLUSTER_VISUAL (maybe others) to TextLayout#getNextOffset TextLayout#getPreviousOffset Add VISUAL_SELECTION as new flag to: TextLayout#draw(G, int, int, int, int, Color, Color, int) This is a lot of work. Block selection will never replace the regular selection. > In StyledText, I currently see the following non-public methods that would be > affected: > - int insertBlockSelectionText(String text, boolean fillWithSpaces) > - void insertBlockSelectionText(char key, int action) > - String getBlockSelectionText(String delimiter) getSelectionRanges() is other places too possibily (didn't check all the references). OK, so by making block selection to be logical, we will cause it to be always continuous in the buffer, but possibly discontinuous in display. This means that user will sometimes see more than 1 block (selection rectangle). I think this behavior is actually inconsistent with the nature of the "block selection" itself. This is a one-off bulk update. (The last one in the triage migration). Moving bugs from swt-triaged@eclipse to platform-swt-inbox@eclipse.org and adding "triaged" keyword as per new triage process: https://wiki.eclipse.org/SWT/Devel/Triage See Bug 518478 for details. Tag for notification/mail filters: @TriageBulkUpdate This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |