Bugzilla – Full Text Bug Listing
| Summary: | [doc] Add help contexts for new target platform work | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Curtis Windatt <curtis.windatt.public> | ||||||||||
| Component: | UI | Assignee: | Ankur Sharma <ankur_sharma> | ||||||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||||||
| Severity: | normal | ||||||||||||
| Priority: | P3 | CC: | caniszczyk, darin.eclipse, gunnar | ||||||||||
| Version: | 3.5 | Flags: | curtis.windatt.public:
review+
darin.eclipse: review+ caniszczyk: review+ |
||||||||||
| Target Milestone: | 3.5 RC3 | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Windows XP | ||||||||||||
| Whiteboard: | |||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 260435, 278231 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Curtis Windatt
Curtis, I think you added the wrong bug. Bug 260345 is a Planet Eclipse one. ;) Oops, should be bug 260435 We should do context help code changes in RC3. Created attachment 137233 [details]
Work in progress patch (do not commit)
Contexts fixed for New target wizard, Edit target defn wizard and target editor. Some of the old target contexts cleaned.
However, some more cleaning and pending contexts remains. So don;t commit the patch yet.
Created attachment 137327 [details]
Work in progress patch
Done:
1) Hookup help contexts for the following places:
Target Pref Page
New Target Wizard
Edit Target Wizard - Add separate contexts for each tab (like the old pref page
did)
Move Target Wizard
New Target Definition File Wizard
Target Editor - Separate contexts for each page, note that each page has a help
button at the top right that needs hooking up.
2) Delete any unused/out of date contexts.
Work In Progress:
Add/Edit new location wizard - Each type of location needs a help context
Import Variables Dialog (on the arguments tab)
Add implicit dependencies dialog
3) Add appropriate links/description to the new contexts.
- Doc isn't finished yet, but a lot of it has been committed.
Work so far looks great Ankur. We need to review and put this in tomorrow, so please concentrate on getting contexts into the code. Here are a couple things I noticed. Let me know if you need help with anything. Preference page context needs work Implicit dependency selection dialog has no context Import arguments dialog has no context Content tab on edit target wizard context does not work if the group is disabled. We could work around this by putting the context on the higher level composite, but I don't know if it is worthwhile. Also once we've added the new contexts we'll need to go through and delete any unused contexts. (In reply to comment #6) > Content tab on edit target wizard context does not work if the group is > disabled. We could work around this by putting the context on the higher level > composite, but I don't know if it is worthwhile. > I know. I didn't find any clean method and for a similar problem I have logged the bug 277996 against Platform UI. Created attachment 137455 [details]
Full Path
Alls done. The description for new contexts remains which will be updated as soon the relevant help pages gets updated. Ready for review.
Awesome, we'll review it asap. Looks good. Just need to hook up the help button (?) in the target editor. Created attachment 137500 [details]
Ankurs Fix + Editor Fix + Delete 3 Unused Contexts
Adds a fix to get the help buttons on the editor to work correctly. Also deleted three contexts for the target provisioners that no longer exist.
+1 Ankur's fix is good. I added a patch with the additional editor fix. I will file a separate bug for updating the links in the contexts against pde doc. +1 Fixed in HEAD. Verified by multiple committers. Thanks Ankur. |