Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 277010

Summary: [ui] unused/dead code in provisioning wizard framework
Product: [Eclipse Project] Equinox Reporter: Susan McCourt <susan>
Component: p2Assignee: Susan McCourt <susan>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 3.5   
Target Milestone: 3.6 M5   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Susan McCourt CLA 2009-05-19 17:26:22 EDT 
3.5 RC1.  While investigating some wizard-related bugs in RC1, I noticed some code oddities that need to be cleaned up.  Should check the history of the files involved to understand why the code is there and verify that it can be punted.  It looks like code that might have been added and then parts of it removed, with useless parts remaining.

They don't seem to cause any harm, but they clutter and confuse the code.

WizardWithLicenses
- addPages() simply calls super.addPages().  There's no change of visibility or other obvious explanation for the override

ProvisioningOperationWizard.getNextPage() sets up a variable "weResolved," passes it to the selectNextPage() method, and that method does nothing with it.  Could get rid of this variable.  selectNextPage() is protected so I suspect at one time there was a subclass that used the variable, but this is no longer the case.

In general the flow from page to page should be reviewed.
Comment 1 Susan McCourt CLA 2009-05-27 16:10:45 EDT 
see also bug 277554.
We need to ensure that we aren't creating pages while the wizard is trying to compute where it's going.  This can result in all kinds of strange things, including the content of one page being hosted inside the title of another...
Comment 2 Susan McCourt CLA 2009-07-09 17:03:31 EDT 
assigning bugs to me that I've marked for 3.6
Comment 3 Susan McCourt CLA 2009-11-11 16:26:32 EST 
Fixed in the p2 API branch.
Comment 4 Susan McCourt CLA 2009-12-01 12:57:15 EST 
changing milestone to M5.  The p2 api branch will be merged back into HEAD early in M5
Comment 5 Susan McCourt CLA 2010-01-26 13:10:40 EST 
verified in I20100126-0100 via source inspection