Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 276745

Summary:	[ui] Login Dialog does not set focus to username
Product:	[Eclipse Project] Equinox	Reporter:	Susan McCourt <susan>
Component:	p2	Assignee:	Susan McCourt <susan>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	john.arthorne, Kevin_McGuire, pascal, susan
Version:	3.5
Target Milestone:	3.6 M2
Hardware:	All
OS:	All
Whiteboard:

Description Susan McCourt

2009-05-18 12:21:38 EDT

+++ This bug was initially created as a clone of Bug #273962 +++

Opening a bug for the specific focus issue, since we may look at fixing this in RC2.

The login dialog tries to set the focus to the username field, but code in MessageDialog ends up setting focus to the default button.  It looks like an override of

customShouldTakeFocus()

to answer true would fix the problem.  (We aren't creating a custom area, but answering true will allow the focus setting in the dialog to prevail).

Long term there's not reason this dialog should subclass MessageDialog, but that can be handled in the long-term bug.

Comment 1 Susan McCourt

2009-05-19 12:11:42 EDT

given this dialog had the same problem in 3.4, I can't justify an RC2 fix.  Changing milestone.

Comment 2 Kevin McGuire

2009-05-19 15:34:35 EDT

I think it's ok to defer, on premise that 99% of the time people cache passwords so in reality get the dialog infrequently.  And, nothing bad happens.

Comment 3 Susan McCourt

2009-09-03 16:10:56 EDT

fixed in HEAD >20090903 by the patch in bug 273962

Comment 4 Susan McCourt

2009-09-15 12:59:31 EDT

verified on I20090915-0100, WinXP, using the test server (http://localhost:8080/never)