Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 276682

Summary:

Anti-aliasing does not work

Product:

[Modeling] GMF-Runtime

Reporter:

Yury Chernikov <me>

Component:

General

Assignee:

Marc Gobeil <mgobeil>

Status:

RESOLVED DUPLICATE

QA Contact:

Severity:

major

Priority:

CC:

ahunter.eclipse, eric.jain, shatalin

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

Windows Vista

Whiteboard:

Bug Depends on:

168311

Bug Blocks:

Attachments:

Description	Flags
screenshot	none
GMF 2.1 screenshot (working with antialiasing)	none
GMF 2.2 screenshot (incorrectly working with antialiasing)	none
patch fix	none

Description Yury Chernikov

2009-05-18 05:59:11 EDT

Build ID: I20090430-2300

Open preference properties for Ecore Diagram Editor.
Select 'Enable anti-aliasing' option.

Editor shows diagram without anti-aliasing.
See attached screenshot.

Bug was reproduced on Windows Vista on GMF M7 and M6 builds. On Linux diagram looks good.

Comment 1 Yury Chernikov

2009-05-18 06:00:31 EDT

Created attachment 136170 [details]
screenshot

Comment 2 Alex Shatalin

2009-05-27 11:08:00 EDT

This problem was caused by following lines recently introduces into Shape.paintFigure(Graphics graphics):

graphics.setAntialias(antialias);
graphics.setAlpha(alpha);

I can restore antialiassing support by commenting out these lines. This change was introduces into CVS with following comment: [168311] gef-head mgobeil 081203 Support the new SWT Line Attributes

After this change all the existing GMF diagrams stop working with antialiassing property (see attached screenshots of geoshapes example).

So, I suggest following solution for now:
- modify Shape code to support "unsettable" antialiassing property and do not callgraphics.setAntialias(antialias) if this attribute was not explicitly set for this Shape instance.

I can not see any other solution for this problem for now.

Comment 3 Alex Shatalin

2009-05-27 11:08:52 EDT

Created attachment 137349 [details]
GMF 2.1 screenshot (working with antialiasing)

Comment 4 Alex Shatalin

2009-05-27 11:09:19 EDT

Created attachment 137350 [details]
GMF 2.2 screenshot (incorrectly working with antialiasing)

Comment 5 Alex Shatalin

2009-05-27 11:10:31 EDT

Setting severity to major - this is a regression problem.

Comment 6 Alex Shatalin

2009-05-27 11:12:02 EDT

adding link to bug #168311 as a reason of this problem

Comment 7 Anthony Hunter

2009-05-27 12:23:58 EDT

Hi Marc, can you look at this.

Could be related to Bug 273541
	
This is definitely related to the work we did in Galileo.

Comment 8 Marc Gobeil

2009-05-27 15:04:14 EDT

Created attachment 137390 [details]
patch fix

Comment 9 Marc Gobeil

2009-05-27 15:08:24 EDT

*** Bug 273541 has been marked as a duplicate of this bug. ***

Comment 10 Marc Gobeil

2009-05-27 15:10:39 EDT

*** Bug 266916 has been marked as a duplicate of this bug. ***

Comment 11 Anthony Hunter

2009-05-28 12:41:38 EDT


*** This bug has been marked as a duplicate of bug 273541 ***

Comment 12 Eclipse Webmaster

2010-07-19 21:59:04 EDT

[GMF Restructure] Bug 319140 : product GMF and component
Runtime was the original product and component for this bug