Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 276162

Summary: [KeyBindings] Exporting key preferences to CSV does not warn of overwriting file
Product: [Eclipse Project] Platform Reporter: Mike Morearty <mike>
Component: UIAssignee: Paul Webster <pwebster>
Status: VERIFIED FIXED QA Contact: Paul Webster <pwebster>
Severity: normal    
Priority: P3 CC: bokowski
Version: 3.5Keywords: helpwanted
Target Milestone: 3.5.1   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 288364    
Attachments:
Description Flags
Proposed patch pwebster: iplog+

Description Mike Morearty CLA 2009-05-13 14:30:33 EDT 
Build ID: I20090430-2300
Tried on both Windows and Mac.

Steps To Reproduce:
1. Preferences, General > Keys
2. Click "Export CSV..."
3. Enter any filename and click OK
4. Do it again: Click "Export CSV...", enter the same filename, and click OK.

Actual result:
The second time, it overwrites the file with no warning.

Expected result:
If you specify the name of an existing file, customary practice on all operating systems is to first warn that you are overwriting a file.
Comment 1 Mike Morearty CLA 2009-05-14 12:39:37 EDT 
Created attachment 135817 [details]
Proposed patch
Comment 2 Paul Webster CLA 2009-05-14 12:48:59 EDT 
Thanx for the patch, I'll look at this in 3.5.1
PW
Comment 3 Paul Webster CLA 2009-08-11 14:11:38 EDT 
The patch looks good (I like simple).

Boris, could I get a +1

PW
Comment 4 Boris Bokowski CLA 2009-08-12 09:44:29 EDT 
+1
Comment 5 Paul Webster CLA 2009-08-12 12:50:57 EDT 
(In reply to comment #1)
> Created an attachment (id=135817) [details]
> Proposed patch

Released to R3_5_maintenance
PW
Comment 6 Paul Webster CLA 2009-08-27 15:20:58 EDT 
In M20090826-1100
PW