Bugzilla – Full Text Bug Listing
| Summary: | Link widget does not support SWT.WRAP | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [RT] RAP | Reporter: | Elias Volanakis <elias> | ||||||||||||
| Component: | RWT | Assignee: | Project Inbox <rap-inbox> | ||||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||||
| Severity: | normal | ||||||||||||||
| Priority: | P3 | CC: | ivan, mknauer | ||||||||||||
| Version: | 1.2 | ||||||||||||||
| Target Milestone: | 1.3 M1 | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | All | ||||||||||||||
| Whiteboard: | |||||||||||||||
| Attachments: |
|
||||||||||||||
Created attachment 137634 [details]
Proposed patch
New client implementation of Link, that supports native wrapping, as in SWT. There is no need of SWT.WRAP style flag, because the link wraps always.
Asen, thanks for the patch. The wrapping works :-). One issue with the patch: Double clicking on the 'linked' part of the link, will select the word underneath. This should not happen, since it does match the behavior in RCP. BTW: Is this going into the next RC? Kind regards, Elias. Created attachment 137829 [details]
Proposed patch
New patch is attached. The problem, reported by Elias is fixed.
My understanding is that this won't be included in the next RC, but please ask Rüdiger for more information.
Created attachment 137830 [details]
Proposed patch
New patch is attached. The problem, reported by Elias is fixed.
My understanding is that this won't be included in the next RC, but please ask Rüdiger for more information.
(In reply to comment #2) > [ ... ] > > BTW: Is this going into the next RC? To fix this bug, the client-side implementation of the Link widget had to be reworked completely. Therefore, it is too risky make these changes in a RC. The code will be available in 1.3M1. Thanks - updated patch works great! :-) Asen, can you provide an updated patch against HEAD ? Thanks, Elias. Created attachment 138371 [details]
Proposed patch
Updated patch against CVS HEAD is attached.
Is to possible to have this go into the 1.3M1 Target Milestone? Sure, that was the plan anyway. Just the target milestone assignment was missing. Thanks for reminding. Applied patch to CVS HEAD |
Created attachment 134586 [details] Sample project The Link widget in RAP does wrap with SWT.WRAP (it rhymes ;-) In RCP it does wrap. The attached example can be used to reproduce.