Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 274889

Summary:

[ui] start levels read-only in product configuration editor

Product:

[Eclipse Project] PDE

Reporter:

Brett Hackleman <bh>

Component:

Assignee:

Chris Aniszczyk <caniszczyk>

Status:

VERIFIED FIXED

QA Contact:

Severity:

critical

Priority:

CC:

aniefer, caniszczyk, cocoakevin, contact, curtis.windatt.public, ruediger.herrmann

Version:

3.5

Flags:

curtis.windatt.public: review+

Target Milestone:

3.5 RC1

Hardware:

OS:

Mac OS X - Carbon (unsup.)

Whiteboard:

Attachments:

Description	Flags
org.eclipse.pde.ui.patch	none
mylyn/context/zip	none

Description Brett Hackleman

2009-05-04 16:05:08 EDT

Builds: 3.5M7 and I20090503-2055

On the Configuration tab of the product file editor, clicking the field for the start level does not allow you to edit the value (true/false).  It does show the correct value, you just can't change it. 

This worked in I20090428-0100.

Comment 1 Chris Aniszczyk

2009-05-04 16:22:00 EDT

Brett, weird, I'm acutally crashing on Cocoa now.

I filed bug 274890 against SWT.

Comment 2 Curtis Windatt

2009-05-04 17:35:20 EDT

*** Bug 274900 has been marked as a duplicate of this bug. ***

Comment 3 Chris Aniszczyk

2009-05-05 10:21:10 EDT

*** Bug 274990 has been marked as a duplicate of this bug. ***

Comment 4 Curtis Windatt

2009-05-06 11:24:47 EDT

Chris, are you able to look at this?

Comment 5 Brett Hackleman

2009-05-07 16:34:33 EDT

FYI, this is still broken in today's I-build on mac/carbon (and probably win32).

The fix in bug 274890 is targeted only at the cocoa crash (which I have not experienced/verified myself).

Chris, any idea if this is due to something that may have changed in PDE during the last week, or if it's still a SWT issue?

Comment 6 Chris Aniszczyk

2009-05-07 16:39:46 EDT

Created attachment 134872 [details]
org.eclipse.pde.ui.patch

We had a focus listener clearing the editors for no reason.

This caused the issue as we disposed of the combo.

Comment 7 Chris Aniszczyk

2009-05-07 16:39:52 EDT

Created attachment 134873 [details]
mylyn/context/zip

Comment 8 Chris Aniszczyk

2009-05-07 16:43:39 EDT

(In reply to comment #5)
> Chris, any idea if this is due to something that may have changed in PDE during
> the last week, or if it's still a SWT issue?

PDE exposed the issue by being naughty (in bug 274890).

We were disposing of a combo when losing focus that we needed. That caused SWT to crash. The fix is to remove the focus listener that was doing this. There's no need to have it.

You can help verify the fix by applying the patch and exporting into your host:

http://eclipsesource.com/blogs/2009/04/23/export-into-the-host-eclipse/

Comment 9 Brett Hackleman

2009-05-07 17:04:12 EDT

Patch works for me here, applied to today's i-build.  Thanks Chris!

Comment 10 Chris Aniszczyk

2009-05-07 18:06:07 EDT

done.

> 20090507

Will leave for Darin to verify and approve.

Comment 11 Curtis Windatt

2009-05-08 12:08:51 EDT

+1 Verified.

Comment 12 Chris Aniszczyk

2009-05-13 15:59:37 EDT

*** Bug 276177 has been marked as a duplicate of this bug. ***