Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 274576

Summary: [publisher] Make the publisher ant task consistent with the others
Product: [Eclipse Project] Equinox Reporter: Pascal Rapicault <pascal>
Component: p2Assignee: P2 Inbox <equinox.p2-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: Ed.Merks, irbull, pnehrer
Version: 3.5   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Attachments:
Description Flags
Patch
none
ProcessRepoTask none

Description Pascal Rapicault CLA 2009-04-30 15:31:47 EDT 
In bug 264110, Matt had started working on improving the publisher ant tasks however it was late to release so we did not. Also we were annoyed that it would have resulted in a large code duplication with code that originally was in the repository tools bundle.
Here is the patch that Matt had originally authored.
Comment 1 Pascal Rapicault CLA 2009-04-30 15:32:52 EDT 
Created attachment 134001 [details]
Patch
Comment 2 Matthew Piggott CLA 2009-05-01 10:51:40 EDT 
Created attachment 134065 [details]
ProcessRepoTask
Comment 3 Ian Bull CLA 2009-06-09 23:41:04 EDT 
I'll look at this early in 3.6 (before Matt's patch gets stale).
Comment 4 John Arthorne CLA 2009-09-16 13:46:41 EDT 
Ian, I'm bumping these again to M3, but please review these bugs and pick a reasonable target (or remove the target if you have no immediate plans to work on them).
Comment 5 Ian Bull CLA 2009-10-15 14:52:58 EDT 
Does anybody know what in particular we want to make consistent?  Matt's patch appears to do the following:

AbstractPublisherTask now extends AbstractRepositoryTask (intead of just Task)
AbstractPublisherTask now includes addConfiguredContext(RepositoryList list)

The rest of the changes appear to be "internal" or simply copies of the code from repo tools.  If we want this code to be consistent with repo tools I suggest we either put a dependency on repo tools or move the tasks to repo tools (otherwise, why do we care?).
Comment 6 Pascal Rapicault CLA 2009-10-19 09:41:31 EDT 
The consistency is at 2 level:
- Ant, so that the task supports the same way of specifying repos and other arguments than the other tasks we have
- Code, so that we have only one copy of the code (though I recognize this may be harder with the current code setup).
Comment 7 Ian Bull CLA 2009-10-20 00:11:38 EDT 
I'm moving this off M3 as I think we need more discussion around this.  I'm leaving this on 3.6.
Comment 8 Ian Bull CLA 2010-03-29 16:10:57 EDT 
I'm moving this out as I won't have time to work on this for 3.6.  It's likely a breaking change anyways.
Comment 9 Eclipse Webmaster CLA 2019-09-06 16:05:47 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 10 Ed Merks CLA 2020-02-20 04:20:58 EST 
Ant tasks are no longer highly relevant in the Maven/Tycho world in which we live today.