Bugzilla – Full Text Bug Listing
| Summary: | [Usability][Navigation] Papyrus shall enable diagram navigation history with back and next buttons | ||
|---|---|---|---|
| Product: | [Modeling] Papyrus | Reporter: | Raphael Faudou <raphael.faudou> |
| Component: | Core | Assignee: | Tristan Faure <faure.tristan> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P4 | CC: | arthur.daussy, cedric.dumoulin, faure.tristan, papyrus-bugs |
| Version: | unspecified | Keywords: | plan |
| Target Milestone: | --- | Flags: | sebastien.gerard:
indigo+
|
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://git.eclipse.org/r/63132 | ||
| Whiteboard: | Usability | ||
| Bug Depends on: | |||
| Bug Blocks: | 361630 | ||
| Attachments: | |||
|
Description
Raphael Faudou
Really important for industrial usage. In addition to "previous" and "next", add "parent" and "root" as in TOPCASED. A minimal specification for navigation buttons that I will develop to fix the bug.
Previous button: open the previous diagram in the stack
Next button: go to the next model if there is one
Parent button:
- if the parent has more than one diagram
o show a popup to suggest all the diagrams with a pre-selection :
The pre-selection algorithm:
1. the opened diagram if there is one
2. the last opened diagram
3. or the first of the list
- if the parent has one diagram, open the diagram or focus on it if it’s already opened
Root button:
- Open the root diagram if there is just one (or the popup if there is more than one)
Or
- Focus on the tab if the parent is already opened
fixed on trunk and branch. nevermind, wrong bug. Created attachment 203592 [details]
patch fixing the bug of navigation
I, Anass Radouani, have written 100% of the code contributed to fix this bug.
I have the right to contribute this code and have filled the headers with the appropriate License.
This contribution has been checked by and committed under the responsibility of Tristan Faure.
A bug remains on the refresh of the navigation buttons to disable or enable them. The refresh is performed after each selection change so the refresh is mage after adding or removing a page from the history.
IMultiEditorManager, SashContainerEventListener and SashWindowsContainer has been moved to a public package because there used in a public Interface. And methods which are part of the API have been changed to public.
Created attachment 203596 [details]
a little missing fixed
a little missing fixed
Created attachment 203757 [details]
adding listener to catch more page changes and add them to the history stack
Created attachment 203842 [details]
patch containing all the changes
commited to trunk and branch 0.8.X modifications in page manger perspective extension for displaying buttons commands implementation This patch has added a useless dependency from oep.sasheditor.di to org.eclipse.gmf.runtime.notation Can you please check that this dependency is unused, and remove it ? This problem exists on both the branch and trunk. I will check this as soon as possible Created attachment 204454 [details]
patch deleting the useless dependencie to org.eclipse.gmf.runtime.notation
The patch remove the unused dependence to org.eclipse.gmf.runtime.notation
The provided implemention has several problems and should be rollback asap. The problems are: - code reformating on existing code - code formating that do not follow Papyrus formating - move of hidden classes from private packages to public packages - Addition of a functionality (command history) that should not be in the sashwindow plugin. This functionality should be handle by the command stack, like all other command history. The modifications from the provided patches introduce errors in the JUnit tests. closing this task verified OK Closed New Gerrit change created: https://git.eclipse.org/r/63132 |