Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 272942

Summary:

Consume org.hamcrest.core from Orbit

Product:

[Eclipse Project] Platform

Reporter:

Markus Keller <markus.kell.r>

Component:

Releng

Assignee:

Kim Moir <kim.moir>

Status:

RESOLVED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

daniel_megert, kim.moir

Version:

3.5

Target Milestone:

3.5 M7

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

Bug Blocks:

266962

Attachments:

Description	Flags
updates orbit.map and org.eclipse.jdt-feature	none
patch for sdk's build.properties	none

Description Markus Keller

2009-04-20 13:48:25 EDT

Created attachment 132464 [details]
updates orbit.map and org.eclipse.jdt-feature

For bug 266962, we need org.hamcrest.core from Orbit. This is actually just a repackaging of content that is currently included in org.junit4. There are no IP strings attached.

Can I (or you) just put the relevant entries into orbit.map and the feature, or is there anything else to do to get this into the build?

Note that I need this from the Orbit I-build, since it was broken in the last stable build (S20090307012903).

Comment 1 Kim Moir

2009-04-21 11:38:28 EDT

Thanks, I'll try your patch out this afternoon when I run another test build.

Comment 2 Kim Moir

2009-04-21 14:39:45 EDT

Created attachment 132652 [details]
patch for sdk's build.properties

Comment 3 Kim Moir

2009-04-21 17:02:09 EDT

Test build successful.  Please tag the jdt-feature once we have this week's i-build signed off, I'll tag the sdk feature.

Comment 4 Markus Keller

2009-04-22 08:39:55 EDT

I checked N20090421-2000, and found that the org.hamcrest.core bundle ended up unpacked in the build (because my patch for org.eclipse.jdt-feature was wrong).

I fixed that in HEAD and I'll release the plug-ins and the JDT feature if it looks good in N20090422-2000.

Comment 5 Markus Keller

2009-04-23 12:09:13 EDT

Looks good in N20090422-2000.

I've tagged org.eclipse.jdt-feature, org.eclipse.jdt.junit, and org.junit4.