Bugzilla – Full Text Bug Listing
| Summary: | [editor] streamline the task editor look-and-feel | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Mik Kersten <mik.kersten> | ||||
| Component: | Mylyn | Assignee: | Mik Kersten <mik.kersten> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | enhancement | ||||||
| Priority: | P3 | CC: | david.shepherd, robert.elves, shawn.minto, steffen.pingel | ||||
| Version: | unspecified | Keywords: | plan | ||||
| Target Milestone: | 3.2 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | 211096, 277970, 277972, 277984, 278133, 278269 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Mik Kersten
Shawn: Could you move "Personal Planning" to below "Attributes"? Misc nits (for Shawn I think): * Rename all instances of "Local" to "Private" * Get rid of "Notes"... * "Planning" (tab) -> "Private" * Fix width problem with "Private" section * Move "Private" section to just below "Attributes" section * The Planning section should be expanded if it has notes or there should be an indication in the section header, e.g. the first sentence of the notes. Shawn, I made the notes expand to the size of the display if there is a lot of text (consistent with the behavior of the description). We could still consider adding a maximize icon to the section header. (In reply to comment #2) > Misc nits (for Shawn I think): > * Rename all instances of "Local" to "Private" Mik, did you want to take care of this one? > * Get rid of "Notes"... Done. I still want to add an overlay if there are no notes so users know what this field is for. > * "Planning" (tab) -> "Private" Done. > * Fix width problem with "Private" section Steffen took care of this. > * Move "Private" section to just below "Attributes" section Done. (In reply to comment #3) > * The Planning section should be expanded if it has notes or there should be an > indication in the section header, e.g. the first sentence of the notes. I have made this auto-expand for now. Lets see what we think. I have also added the save button to the left header to be consistent with the rest of the task editors. Created attachment 137582 [details]
patch for notes overlay
Here is a quick patch for making a text overlay on the notes field when there is not text to inform users of what the field is for. The weird thing about this is that there are multiple viewers on the RichTextEditor, so there is some duplication. Let me know what you think before I commit this change.
Steffen: Could you review? Shawn, have you tried calling editor.getViewer()? That should always return the current viewer. Steffen: Could you add the "Attach File" icon to the Attachments section? (In reply to comment #9) > Steffen: Could you add the "Attach File" icon to the Attachments section? Done. Shawn, it might make sense to enable the repository link in the header of Local task editors now that the Local repository has a settings page. I have added the repository link and have committed my change for the notes (thanks for the pointer steffen). Let me know what you think. I have reverted the right-alignment of the date labels in the header. While it works great on small monitors I found that it is easy to miss the information in the right column since all text is left aligned and the editor only has a single column. All subtasks have been completed. I'm not sure I follow. Was the main problem that on large monitors the dates were easy to miss because the user was not likely to scan the right-hand side of the editor under the toolbar? I could see how that's an issue with the Attributes section open, since that section does not fill available space. But with the Attributes section closed, I thought that the idea was that we would put key attributes on the right side of each collapsed section. Also, with this change that nice separation we had of summary info and dates is gone. I found that I only scan the first 600px of the left column in the task editor when looking at the anything other than comments and description so I repeatedly thought tasks were missing date information. We have also had reports from users who never noticed the icons on the top right of section headers. This might be different if all sections of the task editor filled the horizontal space but with the current design I don't see any benefit in moving the dates or other attribute information to the right. The biggest problem I noticed on small monitors is that when you end up with a horizontal scroll bar the information in the right column is not visible anymore at all without scrolling. As per discussion with Mik we'll keep the left alignment of controls for now to avoid lots of blank space in the center of the header. We may still consider a multi-column layout in the future. Another task bites the dust :) I'm really glad we were able to put all these cycles into the task editor for 3.2. |