Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 271707

Summary:	[publisher] download.md5 for packed files
Product:	[Eclipse Project] Equinox	Reporter:	Henrich Kraemer <henrich.kraemer>
Component:	p2	Assignee:	Matthew Piggott <matthew>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	aniefer, jeffmcaffer, pascal, t-oberlies
Version:	3.5	Keywords:	helpwanted
Target Milestone:	---
Hardware:	PC
OS:	All
Whiteboard:	stalebug
Bug Depends on:
Bug Blocks:	373173

Description Henrich Kraemer

2009-04-08 18:26:20 EDT

Input: directory containing features and plugins

Invoke org.eclipse.equinox.internal.p2.metadata.generator.EclipseGeneratorApplication with the following arguments:
-publishArtifactRepository
-compress
-inplace
-reusePack200Files
-artifactRepository
file:/C:/p2test/input_artifacts/
-metadataRepository
file:/C:/p2test/input_artifacts/
-source
C:\p2test\input_artifacts

The produced artifacts.jar does not have download.md5 property set for packed files. 

All tools updating artifacts.jar should also set their download.md5 (publisher, repo tools)

See also http://dev.eclipse.org/mhonarc/lists/p2-dev/msg01206.html

Comment 1 Henrich Kraemer

2009-04-08 19:33:14 EDT

The link in description was not quite right:
http://dev.eclipse.org/mhonarc/lists/p2-dev/msg01202.html

Comment 2 Jeff McAffer

2009-04-09 00:06:26 EDT

fwiw it the calculation and attachment of the md5 should be in the repo itself not in the tools that are adding things to the repo.  similarly the checking of the md5 should be something that is done as the content is extracted from the repo rather than afterwards.  Not sure if this is what you had in mind but wanted to clarify

Comment 3 Andrew Niefer

2009-04-09 09:46:47 EDT

Calculation of the MD5 currently seems to be done by whoever is creating the descriptor.  This comes down to bug 254652, which kind of fell off the radar.

RE tools, the code is in RecreateRepositoryApplication.recreateRepository

Comment 4 Lars Vogel

2019-11-14 03:42:16 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.