Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 270626

Summary:

[target] Change UI to separate content and location tabs

Product:

[Eclipse Project] PDE

Reporter:

Curtis Windatt <curtis.windatt.public>

Component:

Assignee:

Curtis Windatt <curtis.windatt.public>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

ankur_sharma, caniszczyk, darin.eclipse

Version:

3.5

Flags:

curtis.windatt.public: review? (darin.eclipse)

Target Milestone:

3.5 M7

Hardware:

OS:

Linux

Whiteboard:

Bug Depends on:

Bug Blocks:

272107

Attachments:

Description	Flags
Work In Progress	none
mylyn/context/zip	none
Screenshot of current work	none
Work in progress	none
mylyn/context/zip	none
Work in progress III	none
Work in progress IV	none
Almost complete	none
mylyn/context/zip	none

Description Curtis Windatt

2009-03-31 11:41:36 EDT

When creating the UI we thought we could simplify the UI by having targets always broken down by the locations they came from.  So the contents of targets were displayed as a tree of locations with the plug-ins they contained as children.

Unfortunately several cases have been brought up where users want to work with plug-ins in the target as one large group.  Features like "Select required", group by physical location, etc. require a different UI.

There are a few other benefits to having separate tabs/sections for locations and content.  We will require one less level of modal dialog to edit plug-in content.  The display will more closely match what will eventually end up in the state.

Comment 1 Curtis Windatt

2009-03-31 17:45:00 EDT

Created attachment 130475 [details]
Work In Progress

Comment 2 Curtis Windatt

2009-03-31 17:45:03 EDT

Created attachment 130476 [details]
mylyn/context/zip

Comment 3 Curtis Windatt

2009-04-01 15:19:32 EDT

Created attachment 130605 [details]
Screenshot of current work

Very rough, but it gives you an idea what it would look like.

Comment 4 Curtis Windatt

2009-04-03 13:27:52 EDT

Created attachment 130865 [details]
Work in progress

Adds in the new tab/page and handles target resolution at a higher level.  Still lots of rought edges.  Note that this patch includes some of my work for the p2 target provisioner.

Comment 5 Curtis Windatt

2009-04-03 13:27:55 EDT

Created attachment 130866 [details]
mylyn/context/zip

Comment 6 Curtis Windatt

2009-04-09 18:03:08 EDT

Created attachment 131469 [details]
Work in progress III

Comment 7 Curtis Windatt

2009-04-11 17:14:28 EDT

Created attachment 131554 [details]
Work in progress IV

Still not happy with the code, performance still sucks.  Will have to rethink my approach on Monday.

Comment 8 Curtis Windatt

2009-04-13 19:58:58 EDT

Created attachment 131718 [details]
Almost complete

Things to finish up:
- Fix up the layout in the editor
- NLS strings
- Clean up javadoc

Comment 9 Curtis Windatt

2009-04-13 19:59:03 EDT

Created attachment 131719 [details]
mylyn/context/zip

Comment 10 Curtis Windatt

2009-04-13 23:34:51 EDT

Fixed in HEAD.

There are some outstanding minor UI issues and a more complete test will be necessary to weed out any bugs.  I will file an new report.

Comment 11 Curtis Windatt

2009-04-13 23:36:48 EDT

Darin, please verify.