Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 269959

Summary: Duplicated code in CompareUIPlugin
Product: [Eclipse Project] Platform Reporter: Tomasz Zarna <tomasz.zarna>
Component: CompareAssignee: Platform-Compare-Inbox <platform-compare-inbox>
Status: CLOSED WONTFIX QA Contact: Tomasz Zarna <tomasz.zarna>
Severity: trivial    
Priority: P3    
Version: 3.5   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard: stalebug
Attachments:
Description Flags
Dirty patch
none
mylyn/context/zip none

Description Tomasz Zarna CLA 2009-03-25 07:04:20 EDT 
CompareUIPlugin.findContentViewerDescriptor and CompareUIPlugin.findContentTypeNameOrType (added in bug 268189) have a lot in common in terms of code. It would be best to extract the code to private methods and share it among the two.
Comment 1 Tomasz Zarna CLA 2009-03-25 07:13:03 EDT 
Created attachment 129825 [details]
Dirty patch

A dirty patch which gives the idea, do not commit.
Comment 2 Tomasz Zarna CLA 2009-03-25 07:13:09 EDT 
Created attachment 129826 [details]
mylyn/context/zip
Comment 3 Tomasz Zarna CLA 2009-04-17 08:38:31 EDT 
The same now applies to findStructureViewerDescriptor and findStructureTypeNameOrType, since bug 220457 has been fixed. Also, CompareContentViewerSwitchingPane and CompareStructureViewerSwitchingPane share a lot of code. This could be avoided as well.
Comment 4 Eclipse Webmaster CLA 2019-09-06 16:07:09 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 5 Eclipse Genie CLA 2021-12-22 17:22:10 EST 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.