Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 269290

Summary: provide automated javadoc generation in doc plugin
Product: z_Archived Reporter: Nick Boldt <nboldt>
Component: Dash AthenaAssignee: Common Build Inbox <dash.commonbuilder-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: b.kolb, dash.commonbuilder-inbox, irbull, overholt, wayne.beaton
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Bug Depends on: 272037    
Bug Blocks: 252401, 274170    

Description Nick Boldt CLA 2009-03-18 17:40:46 EDT
The current javadoc generation is a kludge and requires a custom build.xml for the doc plugin, which invariably breaks a build after the feature/plugin is incremented (because that same version is hardcoded in the build.xml).

In addition, the process tends to fail due to various problems such as 

       [build] [Fatal Error] :1:344: An invalid XML character (Unicode: 0x13) was found in the element content of the document.

or

       [build] generateJavadoc:
       [build]     [mkdir] Created dir: /tmp/build/N200903181724/eclipse/plugins/org.eclipse.draw2d.doc.isv/reference/api
       [build]     [mkdir] Created dir: /tmp/build/N200903181724/eclipse/tmp/eclipse/plugins/org.eclipse.draw2d.doc.isv_3.4.1.200903181732
       [build]      [exec] Result: 1
       [build]      [copy] Copying 573 files to /tmp/build/N200903181724/eclipse/tmp/eclipse/plugins/org.eclipse.draw2d.doc.isv_3.4.1.200903181732

And, of course, it's ant calling shell, so it's doomed for use on Win/Mac.
Comment 1 Nick Boldt CLA 2009-04-04 05:18:21 EDT
Maybe we should investigate using the wikitext plugins from Mylyn for generating Eclipse Help (to wrap the javadoc?) in Athena?

http://greensopinion.blogspot.com/2009/04/mylyn-wikitext-produces-pdf.html
Comment 2 Nick Boldt CLA 2009-04-14 13:50:23 EDT
Looks like Andrew's got a solution here (bug 272037); we could look at how to roll this out in a more automated way, or at least document best practices.
Comment 3 Andrew Overholt CLA 2009-04-14 14:20:26 EDT
(In reply to comment #2)
> Looks like Andrew's got a solution here (bug 272037); we could look at how to
> roll this out in a more automated way, or at least document best practices.

The thing I implemented was just to generate user-level documentation -- not javadoc.
Comment 4 Ian Bull CLA 2009-07-29 12:45:47 EDT
I am looking at this bug for Athena and Javadoc generation.

A few things have me stumped.

1. In the custom build.xml, the doc plugin version is set to 3.2.0, but when Athena runs, the plugin has a proper 3.5 version number.  Anybody know why this works?

2. What is the problem with windows? Are you saying that the <exec> calls in Ant don't work on Windows?
Comment 5 Nick Boldt CLA 2009-07-29 16:01:40 EDT
(In reply to comment #4)
> 1. In the custom build.xml, the doc plugin version is set to 3.2.0, but when
> Athena runs, the plugin has a proper 3.5 version number.  Anybody know why this
> works?

Is the build running with forceContextQualifier=true?

> 2. What is the problem with windows? Are you saying that the <exec> calls in
> Ant don't work on Windows?

Your mileage with <exec> will vary across platforms. Staying in Ant (even using <java> is better than <exec>) improves cross-platform portability.

(That said... I've been known to <exec> to use zip or unzip rather than <zip> because antzip != zip in all cases.) 

Comment 6 Ian Bull CLA 2009-07-29 16:17:31 EDT
(In reply to comment #5)
> (In reply to comment #4)
> > 1. In the custom build.xml, the doc plugin version is set to 3.2.0, but when
> > Athena runs, the plugin has a proper 3.5 version number.  Anybody know why this
> > works?
> 
> Is the build running with forceContextQualifier=true?
Nope, but after talking to Andrew N. this is how PDE Build works.  There are still some hardcoded version numbers, but I can fix these -- if you actually look at our docs, it says 3.3 ;)


> 
> > 2. What is the problem with windows? Are you saying that the <exec> calls in
> > Ant don't work on Windows?
> 
> Your mileage with <exec> will vary across platforms. Staying in Ant (even using
> <java> is better than <exec>) improves cross-platform portability.
> 
> (That said... I've been known to <exec> to use zip or unzip rather than <zip>
> because antzip != zip in all cases.) 
> 
Yep, and I think I got the details sorted out for how to use the JavaDoc ant task. 

Nick, how do I get access to be able to run jobs on Hudson?  

Also, when run on Hudson, do the build artifacts get placed on the website automatically?
Comment 7 Nick Boldt CLA 2009-07-29 16:45:56 EDT
(In reply to comment #6)
> Nick, how do I get access to be able to run jobs on Hudson?  

You ask, usally by opening a bug in Community>Hudson. But because I saw this coming a mile away, I've already added irbull to the access list for the GEF 3.5 build. Log in and you can kick builds.

https://build.eclipse.org/hudson/view/Athena%20CBI/job/cbi-gef-3.5/
 
> Also, when run on Hudson, do the build artifacts get placed on the website
> automatically?

They're available in Hudson on build.eclipse.org, eg., here:

https://build.eclipse.org/hudson/view/Athena%20CBI/job/cbi-gef-3.5/lastSuccessfulBuild/artifact/**/*.zip

To appear on www.eclipse.org/gef/downloads/, you have to publish them:

http://wiki.eclipse.org/Common_Build_Infrastructure/Publishing

For more, see:

http://wiki.eclipse.org/Category:Athena_Common_Build
Comment 8 Ian Bull CLA 2009-07-29 16:48:56 EDT
(In reply to comment #7)
> (In reply to comment #6)
> > Nick, how do I get access to be able to run jobs on Hudson?  
> 
> You ask, usally by opening a bug in Community>Hudson. But because I saw this
> coming a mile away, I've already added irbull to the access list for the GEF
> 3.5 build. Log in and you can kick builds.

Thanks, although the foundation is the only place that doesn't know me as irbull.  I'm just ibull :-(
Comment 9 Nick Boldt CLA 2009-07-29 16:58:36 EDT
(In reply to comment #8)
> I'm just ibull :-(

Fixed.


Comment 10 Wayne Beaton CLA 2011-12-22 20:20:35 EST
WONTFIX; Athena is terminated.