| Summary: | [launcher] start levels don't get added when launching without a configurator | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Chris Aniszczyk <caniszczyk> | ||||||||||
| Component: | UI | Assignee: | Chris Aniszczyk <caniszczyk> | ||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||
| Severity: | critical | ||||||||||||
| Priority: | P3 | CC: | bh, jeffmcaffer, phil.kursawe, ulf | ||||||||||
| Version: | 3.5 | ||||||||||||
| Target Milestone: | 3.5 M7 | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Mac OS X - Carbon (unsup.) | ||||||||||||
| Whiteboard: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Chris Aniszczyk
adding context... this problem sucks Created attachment 129291 [details]
mylyn/context/zip
I can attest that this is rather frustrating. Both wether to start and the level are not exported to the config.ini file. Do you need a testcase or is it obvious where the problem is? So the workaround for this problem is to simply use simple configurator. I would also grab this week's i-build when it comes out as it has a lot of fixes around start levels and product definitions. Chris see also #270366. I think this needs to be solved. Will test with newest I-Build tomorrow *** Bug 270366 has been marked as a duplicate of this bug. *** (In reply to comment #5) > Chris see also #270366. I think this needs to be solved. Will test with newest > I-Build tomorrow I am working on this problem but there's a lot of code changes in critical areas so it's going to take awhile. For now, the workaround is to include simpleconfigurator and use those facilities. looking to target next week's i-build with a fix for this. PDE was a much happier place when there were no bundles with multiple versions :/ Created attachment 131513 [details]
org.eclipse.pde.patch
Consolidated some of the launching code.
This patch needs some further work and testing before I release it.
I'm targetting next week's i-build.
Created attachment 131648 [details]
org.eclipse.pde.patch
Here is the final and tested patch.
I dream of a future where we have even more simplified launching code along with unit tests ;)
Created attachment 131649 [details]
mylyn/context/zip
done.
> 20090413
I'd appreciate if people would pickup this week's i-build and test this stuff out in their various usage scenarios.
Using: I20090428-0100 Sorry it's taken me so long to pick up the I-builds and test out the new fixes. I did find one problem with exported products that include bundles configured for the default start level. When the product is exported, the config.ini has: osgi.bundles=com.bandxi.application@0:start, <snip> Launching the product fails with: java.lang.IllegalArgumentException: The requested start level of 0 is invalid. The value must be a positive integer. I'm assuming the fix is to not include the ":<start_level>" for bundles using the default start level when generating the config.ini file. When running the product from within the workbench, the generated osgi.bundles property does not include the start level for these bundles. Thanks! Brett, this is a publisher issue and is being tracked in bug 273961. It should make M7 |