Bugzilla – Full Text Bug Listing
| Summary: | [navigation] Should not have to move mouse to get link behaviour | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Nick Edgar <n.a.edgar> | ||||||
| Component: | Text | Assignee: | Markus Keller <markus.kell.r> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | daniel_megert, deepakazad, hudsonr, jwatt, markus.kell.r, overholt, peter | ||||||
| Version: | 2.1 | ||||||||
| Target Milestone: | 4.3 M1 | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Nick Edgar
I feel that this is a major usability problem with this feature. Simply checking for Ctrl in the mouse click event will not suffice. You want the blue underline to appear when Ctrl is held down before clicking. *** Bug 40504 has been marked as a duplicate of this bug. *** *** Bug 31842 has been marked as a duplicate of this bug. *** We will look into this during 3.2. Sorry, not for 3.2. Created attachment 77623 [details]
Patch to fix hyperlink behaviour
Sorry but the attached patch seems to be corrupted: when applying it says that the file doesn't contain a valid patch. Hi Daniel, don't know whats happening there. If i click "Details" for the patch it can some me the contents correctly. Double check the download and if it's still corrupt i'll upload again tonight. Yeah, I can read and download but Team > Apply Patch... gives me an error. Created attachment 79098 [details]
Patch
Uploaded the patch again Daniel. Hope it works this time...
Sorry but the patch does not work and places the code in the wrong method which is not intended to call showHyperlinks(...). Test Case 1: test on NLS property keys Test Case 2: change the modifier key for Java elements to 'Ctrl+Alt' Also, it deletes commented code. Please don't touch exisiting "code". The copyright needs to be updated with your credentials and the bug, e.g.: Your Name <yourmail.com> - [navigation] Should not have to move mouse to get link behaviour - https://bugs.eclipse.org/bugs/show_bug.cgi?id=26873 (In reply to comment #2) > Simply checking for Ctrl in the mouse click event will not suffice. > You want the blue underline to appear when Ctrl is held down before clicking. The problem with underlining on CtrlDown is that this causes flickering when the mouse is over an identifier and you press an unrelated shortcut. See e.g. bug 25871 comment 7. The best fix is really to check the modifiers in the mouse click event. *** Bug 334246 has been marked as a duplicate of this bug. *** *** Bug 380085 has been marked as a duplicate of this bug. *** Fixed with http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=03b415b2980f64697216f297f75295c1721d3ceb The fix shows the hyperlink on MouseDown (not on KeyDown, see comment 13). It also fixes issues with the Alt key (which at least on Windows does not generate a KeyDown event). > It also fixes issues with the Alt key (which at least on Windows does not
> generate a KeyDown event).
Is that with WPF? I'm pretty sure win32 supported it. Is there a bug open?
> > It also fixes issues with the Alt key (which at least on Windows does not > > generate a KeyDown event). Sorry, the statement in parentheses was wrong. The KeyDown event is fine, but our handling of the KeyDown event was wrong e.g. when Ctrl was held down and then Alt was pressed. We only checked event.keyCode, but missed event.stateMask, which is also relevant in that situation. Clarified this and other comments: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=afd2e060874fe5b032acd2f3f664560a44359eb8 Verified with I20120806-2000 for 4.3 M1 |