Bugzilla – Full Text Bug Listing
| Summary: | Cell editors not accessible | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Modeling] GMF-Runtime | Reporter: | Wayne <wdiu> | ||||||
| Component: | General | Assignee: | Lidija Grahek <lgrahek> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | ahunter.eclipse, lgrahek | ||||||
| Version: | unspecified | ||||||||
| Target Milestone: | 2.2 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
The patch does not solve the scenario in Bug 193757 . so the basic accessibility issue still does not work. We could probably make this a duplicate of Bug 193757 *** This bug has been marked as a duplicate of bug 193757 *** The problem described does sound similar to that of bug 193757, but after looking into both of them more closely, it turns out they are caused by different things. So reopening this defect. Created attachment 147456 [details]
Modified patch
Attached modified patch:
- Left the change to MultiButtonCellEditor as in the original patch.
- Modified change to GMF's ExtendedComboBoxCellEditor: removed adding traversal listener to the parent - it shouldn't be done here, some parent controls already have traversal listener. Also, I don't feel comfortable about removing the selection listener. Instead, I modified its widgetSelected method so it doesn't cause accessibility problem, but is still useful for those who depend on it being there.
Comitted to HEAD, R2_2_maintenance and R2_1_maintenance. (In reply to comment #5) > Comitted to HEAD, R2_2_maintenance and R2_1_maintenance. We did not want this in R2_1_maintenance, so undoing the change here. [target cleanup] 2.2 M7 was the original target milestone for this bug [GMF Restructure] Bug 319140 : product GMF and component Runtime Common was the original product and component for this bug |
Created attachment 128784 [details] Patch to fix problems Build ID: org.eclipse.gmf.runtime.common.ui.services.properties_1.2.0.v20090114-0940.jar Steps To Reproduce: Problems with cell editors: 1. Choose something from a cell editor and focus is lost (ExtendedComboBoxCellEditor). 2. Tab doesn't work at all (ExtendedComboBoxCellEditor). 3. Tab only works between buttons, not cell editors (MultiButtonCellEditor). Please see attached patch which fixes the problems. A07BZ156Q8T2R