Bugzilla – Full Text Bug Listing
| Summary: | [ui] "Install New Software" should only contact the selected sites when resolving an install | ||
|---|---|---|---|
| Product: | [Eclipse Project] Equinox | Reporter: | Susan McCourt <susan> |
| Component: | p2 | Assignee: | Susan McCourt <susan> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | P3 | CC: | ben_hutchison, contact, curtis.windatt.public, dj.houghton, irbull, jamesblackburn+eclipse, jcompagner, john.arthorne, karasiuk, Kevin_McGuire, leberre, martin.skorsky, mober.at+eclipse, pascal, pwebster, recrapiser, rsternberg, ruediger.herrmann, steffen.pingel, susan, ulrich.hobelmann |
| Version: | 3.5 | ||
| Target Milestone: | 3.5 M6 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
|
Description
Susan McCourt
+1 great idea. I think this is the right thing to do. Fixed in HEAD >20090306. There is now a new checkbox at the bottom of the install wizard that says [x] Contact all update sites during install to find required software This is checked by default to preserve the existing behavior. User can uncheck it to restrict the install to only the site(s) selected in the combo. When repos are already loaded and behaving nicely, it's hard to notice the difference between the speed of moving to the next page with the checkbox checked or unchecked. (It is noticeable if you are specifically looking for it, but not significantly different). When sites are not loaded/cached or user is disconnected and the checkbox is checked, using the next button can take some time. Same hang that used to happen when trying to open the wizard. At this point, the user can push cancel in the wizard, which will stop the repo contact and keep the user on the first page. At this point, you can uncheck the checkbox. A disconnected user, then, would typically either have a single local site selected in Work With: (often it's a site they have just added), or else they could select "Only Local Sites." With the checkbox unchecked, they can then work without ever contacting a remote site during an install. I verified this is true using breakpoints on all repo loads. Things we can still argue about: ;-) 1) Is the checkbox too subtle? It might be. However, I didn't want to insert an extra modal decision point in the wizard workflow by, for example, always trying the scoped operation and then asking "do you want to try again with everything?" This penalizes users who were happy with the old behavior/didn't notice because the repos are loaded and responsive. 2) Should we default to unchecking the box (scoping the install by default?) Maybe. Given this is the last dev day of M6, I didn't want to change the default since we are not sure what the impacts are. For example, we don't want to cause a bunch of new "can't install Xxx" bugs from users who were happy before and now can't find their required software because we are only looking in a single site. This seemed to risky to take on, and more appropriate to examine in light of the new explanation support for errors. I opened bug 267464 (targeted for M7) to further explore directing the user to the checkbox when they cancel or fail. See that bug for ideas. Note that we don't use this "restricted provisioning" in the update or uninstall wizard, because we currently don't track a relationship between an installed IU and the site it came from. Disconnected users will still experience some pain when uninstalling, updating, or reverting. The fact that we contact sites during uninstall is covered in bug 243375. To discourage client code from contacting the world inadvertently, I changed the UI utility methods that do planning and provisioning operations to explicitly require the ProvisioningContext (repo list). The old methods are deprecated. Opened bug 267452 on PDE to look at the use of deprecated methods in PDE and potentially avoid contacting the world when not needed. *** Bug 267534 has been marked as a duplicate of this bug. *** *** Bug 272422 has been marked as a duplicate of this bug. *** |