Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 266186

Summary:	[About] Provide hooks for copy and select all for Installation Pages
Product:	[Eclipse Project] Platform	Reporter:	Susan McCourt <susan>
Component:	UI	Assignee:	Platform UI Triaged <platform-ui-triaged>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	bokowski, georg.sendt, gleblanc, Kevin_McGuire, leberre, prakash, pwebster, remy.suen, susan
Version:	3.5
Target Milestone:	---
Hardware:	PC
OS:	All
Whiteboard:	stalebug

Description Susan McCourt

2009-02-25 13:35:39 EST

Opened this for the specific discussion in bug #265204.
It would be nice for contributed pages in the Installation Page framework to be able to easily support copy and select all commands without having to set up the context/source variable infrastructure required to do so.

I ended up developing a small ICopyable framework in p2 that allows a page to
register which controls support copy, and have a handler installed that
redirects the command back to the page. The focus service and handler
activation is handled for free.  

This could easily be extended to select all, also.
Another question: apart from the keybindings, where does copy appear?  
- p2 is currently using a popup menu on the control for copy
- the "configuration" page is currently using a button at the bottom

I prefer the popup menu approach since most people will use the keybinding first and I don't see using valuable button real estate for these commands.

Comment 1 Susan McCourt

2009-02-25 13:37:10 EST

marking M6 since this is effects the API.
I'm doubtful I'll get to it, but we'll see.  If not, it can be a 3.6 item.

Comment 2 Susan McCourt

2009-02-25 13:40:38 EST

*** Bug 265212 has been marked as a duplicate of this bug. ***

Comment 3 Kevin McGuire

2009-02-26 11:59:07 EST

I always think I should be able to copy *any* string I see in Eclipse.  The framework sounds interesting.

Comment 4 Susan McCourt

2009-02-26 12:26:46 EST

(In reply to comment #3)
> I always think I should be able to copy *any* string I see in Eclipse.  The
> framework sounds interesting.
> 
What do you think about affordances?  If *everything* supported copy it wouldn't matter, but given the reality, do you think we should worry about one?  

I'm using a popup in p2 (not exactly an affordance since the user has to do something to see it). I basically chose to do what the current error dialog does...

Comment 5 Susan McCourt

2009-03-03 18:32:58 EST

something to consider for 3.6...

Comment 6 Susan McCourt

2009-06-03 14:19:59 EDT

*** Bug 181258 has been marked as a duplicate of this bug. ***

Comment 7 Susan McCourt

2009-06-03 14:21:18 EDT

*** Bug 227114 has been marked as a duplicate of this bug. ***

Comment 8 Susan McCourt

2009-06-03 14:24:07 EDT

*** Bug 239771 has been marked as a duplicate of this bug. ***

Comment 9 Susan McCourt

2009-06-25 14:16:25 EDT

assigning milestone for investigation in 3.6

Comment 10 Susan McCourt

2009-12-03 16:34:59 EST

I'm going to first look at whether there's a relatively simple way to provide generic copy support in a WidgetMethodHandler, similar to how the SelectAllHandler works today.  The handler could either look for certain methods via reflection, or perhaps have some special case by case treatment for tables and lists.  If this could replace the p2 ICopyable support, that would be the best.  ICopyable is general in that it lets the implementor decide exactly what should be copied.  However, I think it's reasonable to assume that the user wants to copy exactly what they see, so there shouldn't need to be any work at the page level to define copy semantics.

This would make it easier for any dialog (not just about) to then hook in the handler.

We would do this for the installation pages.  We would also need to:
- provider a helper method for creating a copy/select all context menu that can be placed on a list
- remove the copy... button from the configuration page

Comment 11 Susan McCourt

2011-04-19 16:51:43 EDT

unassigning bugs without milestones

Comment 12 Lars Vogel

2019-11-14 02:15:03 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.