Bugzilla – Full Text Bug Listing
| Summary: | Text is clipped while direct editing a label | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Modeling] GMF-Runtime | Reporter: | Alex Boyko <aboyko> | ||||
| Component: | General | Assignee: | Alex Boyko <aboyko> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | ahunter.eclipse, richard.gronback | ||||
| Version: | 2.1 | ||||||
| Target Milestone: | 2.2 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | 2.1.4 Patch | ||||||
| Attachments: |
|
||||||
Patch looks good to me. This cannot go on 2.1.3 as Ganymede SR2 is closed / out the door. This cannot go on 2.2 as the problem does not occur there. This cannot go on 2.1.4 as such a release does not exist / is not planned and we are not creating a release for one defect. For now, I removed the target milestone and added "2.1.4 Patch" to the Whiteboard. We can commit to R2_1_Maintenance and create a patch if we feel this is a critical issue. The patch looks good, please commit to HEAD and R2_1_Maintenance. The version of the org.eclipse.gmf.runtime.draw2d.ui bundles also needs to change to 1.2.4 to indicate a change post GMF 2.1.3. (In reply to comment #2) > The version of the org.eclipse.gmf.runtime.draw2d.ui bundles also needs to > change to 1.2.4 to indicate a change post GMF 2.1.3. > That is 1.1.4. Changed the plugin version to 1.1.4 and committed the fix to maintenance stream. We missed HEAD in Feb, I have now propagated the fix to HEAD and R2_2_maintenance. [GMF Restructure] Bug 319140 : product GMF and component Runtime Diagram was the original product and component for this bug |
Created attachment 126613 [details] proposed patch The text control within the cell editor is created with SWT.WRAP | SWT.MULTI style on it. If there is not enough room to paint the text within the control text is "paged" thus the "page" displayed contains only the last character. The rest of the text is diplayed on the first "page" and user has to navigate to it with arrow keys. This is a regression from 2.1.2. Regression, because in 3.4.2 GDI+ isn't well supported and we are forced to use GDI only to calculate the size of the string in pixels.