Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 265524

Summary: Repo2RunnableTask should create jar:file: URIs for zipped repos
Product: [Eclipse Project] Equinox Reporter: Andrew Niefer <aniefer>
Component: p2Assignee: P2 Inbox <equinox.p2-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: pwebster, susan
Version: unspecified   
Target Milestone: 3.5 M6   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 264868    
Attachments:
Description Flags
patch none

Description Andrew Niefer CLA 2009-02-19 14:14:28 EST 
When Repo2RunnableTask is given source repos that are zips of repos, then instead of creating normal file: uris, we should create jar:file: uris (ie jar:file:D:\temp\zzz.repo.zip!/) so that we can use the archive directly.

See AbstractRepositoryTask#prepareSourceRepos
Comment 1 Susan McCourt CLA 2009-02-19 21:56:44 EST 
I'd like to see some utility methods that the tooling apps and the UI could use for stuff like this, otherwise we are duplicating this code everywhere.... (ie, see org.eclipse.equinox.internal.provisional.p2.ui.policy.RepositoryLocationValidator).
Comment 2 Andrew Niefer CLA 2009-02-20 09:58:40 EST 
Created attachment 126299 [details]
patch

The test in this patch is failing intermittently.
Comment 3 Andrew Niefer CLA 2009-02-20 12:05:12 EST 
I have released this change (see bug 265564 where the intermittent problem is resolved).

I have raised bug 265678 to create a standard utility for doing these URIs.