Bugzilla – Full Text Bug Listing
| Summary: | Moving command framework to web services project | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP Webservices | Reporter: | Kathy Chan <kathy> | ||||||||||
| Component: | wst.ws | Assignee: | Keith Chong <keith.chong.ca> | ||||||||||
| Status: | CLOSED FIXED | QA Contact: | Kathy Chan <kathy> | ||||||||||
| Severity: | enhancement | ||||||||||||
| Priority: | P3 | CC: | david_williams, d_a_carver, keith.chong.ca, konstantin, webmaster | ||||||||||
| Version: | 3.1 | Keywords: | plan | ||||||||||
| Target Milestone: | 3.1 M6 | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Windows XP | ||||||||||||
| Whiteboard: | Other | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 266893 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Kathy Chan
+1 I'm in favor of this move. Just to document it explicitly, this would not involve changing package names, to avoid breaking adopters (and our own webservices code), and in addition leaving the names the same maintains the history in cvs. It's my opinion this would not have to go forward for "move review" with Eclipse Foundation, since there's no real change of scope or mission of either Project ... it's more of a correction of decisions made long ago ... but I'll sanity check with some in Eclipse Foundation. (If it is recommended to have a move review, it'd be a pretty simple one). Accordingly, I think the mechanical items that have to occur (assuming there's no objections) are 1. get the webmasters to do a "move" of the cvs directories. 2. change some feature definitions to include these in webservice features -- at least, do that in HEAD ... I think it's debatable if we should change maintenance stream features ... technically we should not, but doubt it would impact anyone. 3. update the map files to point to the new cvs locations (and, move them into webservices maps). NOTE: these map locations have to be changed in current and past maps. I suggest we do the HEAD and 3.0.x maintenance ones ... but leave other steams as is, until we need some new build from some old stream. I suggest we aim to do this after "3.0.4" is released (2/25) but before M6 (3/20) ... so, pretty small window. I would suggest putting these plugins in their own feature so that whoever needs this do not necessarily need to pull in other Web services plugins. I suggest org.eclipse.wst.command_core.feature and org.eclipse.wst.command_ui.feature. We should limit the change in HEAD. I think that in general, we are trying to move away from core/ui split at feature level. Unlike the split at the plugin level, such a split hasn't proven to be valuable either to end users or downstream adopters. I would suggest a single feature for all of the command framework plugins. Also, I would highly recommend that the feature id include "webservices" in it. I also see org.eclipse.wst.command.env.doc.user org.eclipse.wst.command.env.infopop that on the surface would appear related to these being moved ... so should they be moved too? Or are the names deceptive? I looked for JUnit test bundles that might be for these "command.env" bundles and did not see any, but will you please confirm? And, to be explicit, I have confirmed with EMO that no move review is required for this case. Yes. These plugins should be moved as well: org.eclipse.wst.command.env.doc.user org.eclipse.wst.command.env.infopop There are no JUnit plugin. We are currently checking with users of these plugins in adoptor product to see what would be the best feature structure for these plugins. Webmasters, can we get your help moving this CVS code? To be exact, we need to move common/plugins/org.eclipse.wst.command.env common/plugins/org.eclipse.wst.command.env.core common/plugins/org.eclipse.wst.command.env.ui common/docs/org.eclipse.wst.command.env.doc.user common/docs/org.eclipse.wst.command.env.infopop to, respectively, webservices/plugins/org.eclipse.wst.command.env webservices/plugins/org.eclipse.wst.command.env.core webservices/plugins/org.eclipse.wst.command.env.ui webservices/docs/org.eclipse.wst.command.env.doc.user webservices/docs/org.eclipse.wst.command.env.infopop We want to do it in a way that maintains the cvs history, of course. If I recall, last time we did something similar, we just had to do something like rsync --recursive $FROMDIR $TODIR but you'd know best (and, delete the old directory, once confirmed all verifies). and, if I recall you subsequently had to fix permissions so they had the correct group associated with it. In this case, that new group id would be webtools.webservices-dev (you can use my id for user owner, if it matters ... or, anyone in the webtools.weservices-dev group (probably shouldn't leave 'root' as the owner I'd guess?) Now ... for schedule ... Monday March 2 would probably be the ideal day if you can reserve a few hours then. But, a few days plus or minus would work fine too. Sound doable? Any suggestions to improve the process outlined above? Would you prefer me to do the "copy" as long as you were available to change the group ID? (That's the way we did it last time, but then there were scores to move, and I think you didn't trust yourselves to run my script :) Much thanks, Ok, I've set a reminder for 9am Monday March 2nd. This seems like a fairly straight forward move. -M. The org.eclipse.wst.command.env.doc.user plugin is in the org.eclipse.wst.ws_userdoc.feature Created attachment 127060 [details]
Patch to remove plugins from Common features
This patch affects the two Common features:
org.eclipse.wst.common_core.feature
org.eclipse.wst.common_ui.feature
Created attachment 127062 [details]
Web Services Feature changes
This patch affects org.eclipse.wst.ws_core.feature and org.eclipse.wst.ws_ui.feature.
Created attachment 127159 [details]
Map Files patch (HEAD)
I've copied the data and changed the group. When everything checks out let me know and I'll remove the 'old' data. -M. Created attachment 127165 [details]
Web Services Feature changes
Reversion web service features to 3.1.0 to match release
Comment on attachment 127159 [details]
Map Files patch (HEAD)
Entries should be moved to the web services maps. The changes have been checked in.
(In reply to comment #14) > I've copied the data and changed the group. When everything checks out let me > know and I'll remove the 'old' data. > -M. Hi Matt, other Eclipse Web Masters, Go ahead and remove the 'old' data. Also, can you please update the MODULES file so that the top level plugins are correctly linked? Should be like this: org.eclipse.wst.command.env webservices/plugins/org.eclipse.wst.command.env org.eclipse.wst.command.env.core webservices/plugins/org.eclipse.wst.command.env.core org.eclipse.wst.command.env.doc.user webservices/docs/org.eclipse.wst.command.env.doc.user org.eclipse.wst.command.env.infopop webservices/docs/org.eclipse.wst.command.env.infopop org.eclipse.wst.command.env.ui webservices/plugins/org.eclipse.wst.command.env.ui Done. -M. Resolving bug as fixed. Verified during 3.1 M6. Closing bug. |