Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 263712

Summary: ACStart.sh incorrectly reports ACServer started successfully
Product: z_Archived Reporter: Alan Haggarty <haggarty>
Component: TPTPAssignee: Sean Lamers <slamers>
Status: CLOSED FIXED QA Contact:
Severity: major    
Priority: P3 CC: jcayne, jgwest, kathy
Version: unspecifiedFlags: jcayne: review+
jcayne: review?
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard: closed471
Attachments:
Description Flags
patch for bug 263712 slamers: review?

Description Alan Haggarty CLA 2009-02-04 17:51:19 EST 
Build ID: M20080221-1800 

Steps To Reproduce:
1. install agent controller and run SetConfig with proper values.
2. open config/serviceconfig.xml, search for "Application", replace the second instance with "Application2"
3. save serviceconfig.xml
4. run ACStart.sh

Result is:
[ractest@tptp-seahawk bin]$ ./ACStart.sh
Starting Agent Controller.
Error reading the Agent Controller configuration file. Please check for valid configuration.Could not start Agent Controller.ACServer started successfully.
[ractest@tptp-seahawk bin]$

Notice at the end "ACServer started successfully." is tacked on. This is not true in this case.


More information:
Comment 1 Kathy Chan CLA 2009-04-23 09:24:43 EDT 
Hi Joel,

Could you please take a look as you are more knowlegeable in bash script?

Thanks!
Comment 2 Joel Cayne CLA 2009-05-08 16:31:29 EDT 
Sean,

Please see what you can do to update the script.

Thanks!
Comment 3 Sean Lamers CLA 2009-05-11 12:08:09 EDT 
Created attachment 135164 [details]
patch for bug 263712

Joel please review.
Comment 4 Joel Cayne CLA 2009-05-11 13:21:49 EDT 
Patch looks good.
Comment 5 Joel Cayne CLA 2009-05-11 13:27:22 EDT 
Kathy,

On behalf of Sean, I would like to request that the following defect be considered for Platform project approval for 4.6.0.

1.  Explain why you believe this is a stop-ship defect. How does the defect manifest itself, and how will users of TPTP / consuming products be affected if the defect is not fixed?

The Agent Controller will be reported as started/shutdown when the state has not changed.

2. Is there a work-around? If so, why do you believe the work-around is insufficient?
No

3. Is this a regression or API breakage? Explain.
No.

4. Does this require new API?
No.

5. Who performed the code review?
Joel

6. Is there a test case attached to the bugzilla record?
No, this bugzilla will be encountered in most testing of the Agent Controller.

7. What is the risk associated with this fix?
Low.

8. Is this fix related to any standards that TPTP adheres to? If so, who has validated that the fix continues to adhere to the standard?
No.
Comment 6 Kathy Chan CLA 2009-05-12 11:02:20 EDT 
+1 for checking into TPTP 4.6.
Comment 7 Joel Cayne CLA 2009-05-12 11:13:18 EDT 
Patch checked into HEAD.
Comment 8 Kathy Chan CLA 2010-11-18 18:56:47 EST 
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.