Bugzilla – Full Text Bug Listing
| Summary: | Version Numbering | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Bjorn Freeman-Benson <bjorn.freeman-benson> | ||||||
| Component: | Eclipselink | Assignee: | Nobody - feel free to take it <nobody> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P1 | CC: | douglas.clarke, peter.krogh | ||||||
| Version: | unspecified | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 245174, 252796 | ||||||||
| Attachments: |
|
||||||||
|
Description
Bjorn Freeman-Benson
Here is the eclipselink.jar manifest from our 1.0.2 release. Manifest-Version: 1.0 Ant-Version: Apache Ant 1.7.0 Created-By: 2.4 (IBM Corporation) Specification-Title: Eclipse Persistence Services Specification-Vendor: EclipseLink Project Specification-Version: 1.0.2 Implementation-Title: org.eclipse.persistence Implementation-Vendor: EclipseLink Project Implementation-Version: 1.0.2.20081024 For our bundles we are currently creating manifests like: Manifest-Version: 1.0 Ant-Version: Apache Ant 1.7.0 Created-By: 2.4 (IBM Corporation) Bundle-ManifestVersion: 2 Bundle-Name: EclipseLink JPA Bundle-SymbolicName: org.eclipse.persistence.jpa Bundle-Version: 1.0.1 Require-Bundle: org.eclipse.persistence.core;bundle-version="[1.0.0,2. 0.0)";visibility:=reexport The Bundle-Version needs to be changed to match the Implementation-Version from the first example. The JavaDoc requirements listed cannot be met as much of our API pre-exists the contribution to Eclipse and we do not want to lose the 12+ years of history captured in those comments. We will attempt to leverage this pattern for new API that will be exposed publicly from our bundles or bundles we contribute to Orbit. Please address Bug 245174 at the same time and add the vendor name to the manifest. I will research the correct name. Appearently "Bundle-Version:" needs to be the fully qualified build number: ie: 1.1.0.v200904015-r3834 Also, we need to add "Bundle-Vendor:" will be using "EclipseLink Project" as the string for all the jars we create (not necessarily have coded - javax.persistence and commonj.sdo will also use this string), since we created the artifact and are distributing it. Finally, There is a requirement to add "Java-ExecutionEnvironment:" to specify the minimum requirement to execute the containtain code - we will be specifying "J2SE-1.5" due to our use of annotations. Created attachment 131008 [details]
Changes needed for versioning changes.
- Change in our versioning standard ("Version.rRevision-BldType" to "Version.vDATE-rRevision")
- Adjust our generation strategy so we don't create "dirty" Manifests that could be accidently be checked in.
-Local builds will generate with "Version.qalifier" - i.e.: "1.1.1.qualifier".
- Added "Bundle-Vendor: EclipseLink Project", and "Bundle-ExecutionEnvironment: J2SE-1.5" to our OSGi bundles.
- Cleaned up related areas of the MW builds.
- Added build-time variables, for possible future use to all pertinent builds.
Created attachment 131010 [details]
A few more fixes to javax.persistence.jar generation
There were two manifest files included. fixed so only included one.
Merged after cursory review by Tom. the merge worked as expected. change to the default was required though (had to undo the default of "${Version}.qualifier" temporarily).
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink |